Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump prettier and @types/prettier #4384

Closed
wants to merge 4 commits into from
Closed

Conversation

wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Jul 16, 2024

Details

Fixes the license file script that was failing in #4382. Based on #4140 (comment), this PR still might fail CI, but we'll see!

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

GUS work item

dependabot bot and others added 2 commits July 16, 2024 14:18
Bumps [prettier](https://github.com/prettier/prettier) and [@types/prettier](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/prettier). These dependencies needed to be updated together.

Updates `prettier` from 2.8.8 to 3.3.3
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@2.8.8...3.3.3)

Updates `@types/prettier` from 2.7.3 to 3.0.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/prettier)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-major
- dependency-name: "@types/prettier"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@wjhsf wjhsf requested a review from a team as a code owner July 16, 2024 16:21
default value in v2 was "es5", default in v3 is "all"

using the old default minimizes the changes
@wjhsf wjhsf mentioned this pull request Jul 16, 2024
@wjhsf
Copy link
Contributor Author

wjhsf commented Jul 16, 2024

As expected, it failed, but I filed #4386 to fix and did some prep work in #4387.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant