Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependabot): ignore prettier v3 #4387

Merged
merged 3 commits into from
Jul 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,8 @@ updates:
# We are pinned to Tachometer 0.5.10 due to a breaking change in 0.6.0.
# See: https://github.com/google/tachometer/issues/244
- dependency-name: 'tachometer'
# TODO [#4386]: Stop ignoring when we've done the upgrade ourselves
- dependency-name: 'prettier'
versions: '>= 3'
- dependency-name: '@types/prettier'
versions: '>= 3'
3 changes: 2 additions & 1 deletion .prettierrc
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"printWidth": 100,
"singleQuote": true,
"tabWidth": 4
"tabWidth": 4,
"trailingComma": "es5"
}
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ describe('fixtures', () => {
);

return {
// TODO [#4386]: Prettier v3 returns a promise - add an `await` here
'expected.js': prettier.format(code, { parser: 'babel' }),
'ast.json': JSON.stringify({ root }, null, 4),
'metadata.json': JSON.stringify({ warnings }, null, 4),
Expand Down
1 change: 1 addition & 0 deletions scripts/tasks/generate-license-files.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ async function main() {
'\n'
)}`.trim() + '\n';

// TODO [#4386]: Prettier v3 returns a promise - add an `await` here
const formattedLicense = prettier.format(newLicense, {
parser: 'markdown',
});
Expand Down
Loading