fix: fix light dom slot forwarding bug #4452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Aug 9, 2024
nolanlawson
commented
Aug 9, 2024
nolanlawson
commented
Aug 9, 2024
nolanlawson
commented
Aug 9, 2024
|
I think this should also resolve #3731 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes #4446, partially reverts #4258.
The main thing this PR does is revert us from the 252 behavior to the 250 behavior, while also adding additional code to ensure that
disconnectedCallbackfires correctly. The bulk of what you need to know is in the code comments.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
The ordering of
disconnectedCallbacks firing in light DOM may change when using slot forwarding.