chore: fix type errors in test files during dev #4458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cardoso
commented
Aug 13, 2024
| @@ -22,6 +22,8 @@ interface CustomMatchers<R = unknown> { | |||
| toBeInRange: (range: { min: number; max: number }, key: string) => R; | |||
| } | |||
|
|
|||
| import 'vitest'; | |||
There was a problem hiding this comment.
This is actually needed for the augmentation to work...
There was a problem hiding this comment.
Let's move this up to the top of the file. I'm surprised this doesn't fail the linter.
nolanlawson
reviewed
Aug 19, 2024
| @@ -60,6 +60,7 @@ function sharedPlugins() { | |||
| return [ | |||
| typescript({ | |||
| tsconfig: path.join(packageRoot, 'tsconfig.json'), | |||
| exclude: ['**/__tests__/**'], | |||
There was a problem hiding this comment.
Right, because we still need typechecking in __tests__, we just don't want to do anything with it during the Rollup step.
|
/nucleus test |
nolanlawson
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure vscode picks up vitest/globals.
Details
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item