fix(ssr): remove unused imports #4873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Nov 15, 2024
| @@ -235,6 +231,8 @@ export const Element: Transformer<IrElement | IrExternalComponent | IrSlot> = fu | |||
| childContent = []; | |||
| } | |||
|
|
|||
| cxt.hoist(bImportHtmlEscape(), importHtmlEscapeKey); | |||
|
|
|||
There was a problem hiding this comment.
We can probably simplify our ctx.hoist() logic elsewhere as well (since we can basically just import everything from @lwc/ssr-runtime once and let the optimizer do its magic) but I've punted on that for now.
ekashida
approved these changes
Nov 15, 2024
nolanlawson
commented
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes #4793.
This solves the Gordion knot by cutting it. I added an extra AST transform to remove unused imports from
@lwc/ssr-runtime. This means we don't need to manually track any imports during AST generation.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?