feat(engine): inline styles to support native shadow #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark resultsBase commit: lwc-engine-benchmark
|
caridy
force-pushed
the
caridy/style-refactor
branch
from
556ee02
to
d3ed20f
Compare
Benchmark resultsBase commit: lwc-engine-benchmark
|
|
@pmdartus this is now ready to roll! you can base your branch for compiler off this branch. |
pmdartus
reviewed
Sep 13, 2018
| } else { | ||
| // native shadow in place, we need to act accordingly by using the `:host` | ||
| // selector, and an empty shadow selector since it is not really needed | ||
| const textContent = style(':host', ''); |
There was a problem hiding this comment.
After working #637, replacing the token there will not work. We need to duplicate the CSS rule to make this work.
// Original
:host(.active) {}
// Transformed
[host-token].active {}
// With the :host replace at runtime
:host.active {}
Benchmark resultsBase commit: lwc-engine-benchmark
|
pmdartus
changed the title
Benchmark resultsBase commit: lwc-engine-benchmark-ie11
|
pmdartus
force-pushed
the
caridy/style-refactor
branch
from
7576413
to
aae9989
Compare
Benchmark resultsBase commit: lwc-engine-benchmark-ie11
|
Benchmark resultsBase commit: lwc-engine-benchmark-ie11
|
pmdartus
force-pushed
the
caridy/style-refactor
branch
from
aae9989
to
8eab8c6
Compare
Benchmark resultsBase commit: lwc-engine-benchmark
|
apapko
approved these changes
Oct 9, 2018
|
Please ignore my accidental approval |
Benchmark resultsBase commit: lwc-engine-benchmark
|
|
I ok with both approaches. |
|
@diervo, can you comment here? |
pmdartus
reviewed
Oct 10, 2018
|
|
||
| // Inserting a placeholder for <style> to guarantee that native and synthetic shadow markup | ||
| // are identical. | ||
| styleElement = getCachedStyleElement(process.env.NODE_ENV !== 'production' ? `/* synthetic style for component ${shadowSelector} */` : ''); |
pmdartus
reviewed
Oct 10, 2018
| @@ -133,6 +113,10 @@ export function evaluateTemplate(vm: VM, html: Template): Array<VNode|null> { | |||
| } | |||
| const vnodes = html.call(undefined, api, component, cmpSlots, context.tplCache); | |||
|
|
|||
| const { styleVNode } = context; | |||
| // inserting the style tag at the top always | |||
| ArrayUnshift.call(vnodes, isUndefined(styleVNode) ? null : styleVNode); | |||
There was a problem hiding this comment.
Add a surrounding branch to not do the unshift if the styleVNode is undefined.
fix(engine): integration test feat(compiler): inline styles to support native shadow (#691) Add compiler changes required for the shadow DOM injection of the stylesheet. The CSS transformer now attach to the template an object with 3 properties: * `hostAttribute` - the attribute to apply to the host element * `shadowAttribute` - the attribute to apply to the shadow elements * `factory` - a function accepting a `hostSelector` and a `shadowSelector` to apply to the styles. Note the difference in naming, `hostAttribute` is the attribute name, while the factory excepts a selector `[attr]`. This changes is necessary to be able to generate at runtime both native and synthetic shadow compatible stylesheets. Changes: * Make changes to the CSS transform, it nows accepts 2 parameters a `hostSelector` and a `shadowSelector`. * Update the compiler produce the new `Stylesheet` format for runtime consumption * Update references to `styleToken` in the engine code to `styleAttribute` to better match the actual purpose * [ ] Yes * [X] No - as long as nobody is invoking the CSS transform manually since it's signature changed fix: removed file missed during squash
diervo
force-pushed
the
caridy/style-refactor
branch
from
ec5f10a
to
bd13dbd
Compare
added 2 commits
October 11, 2018 09:45
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
template.stylecan be a function that when invoked, returns the inline stylestyleelement is always the first element in the shadow if the rendered template hasstylepropertyThis is PR is compatible with the existing compilation, it supports both mechanism. Eventually, once the compiler updates, we can remove the forking logic in tests and update template.ts to always rely on the style function instead of the template to extract tokens.
Does this PR introduce a breaking change?