Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollup-plugin-lwc-compiler): Fix peer-dependencies #59

Merged
merged 1 commit into from
Feb 5, 2018

Conversation

pmdartus
Copy link
Member

@pmdartus pmdartus commented Feb 5, 2018

Details

When running installing the latest lwc-engine, lwc-compiler and rollup-plugin-lwc-compiler, npm is complaining that the rollup plugin doesn't meet the peer dependency requirements:

$ npm install --save-dev lwc-engine lwc-compiler rollup-plugin-lwc-compiler
npm WARN [email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.

Note: The peer-dependency has been updated to accept fix (using the ~ modifier) on lwc-compiler and lwc-engine.

Does this PR introduce a breaking change?

  • Yes
  • No

@pmdartus pmdartus requested a review from diervo February 5, 2018 18:02
@pmdartus pmdartus changed the title bug(rollup-plugin-lwc-compiler): Fix peer-dependencies fix(rollup-plugin-lwc-compiler): Fix peer-dependencies Feb 5, 2018
@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: bbb75de | Target commit: da6d8a6

benchmark base(bbb75de) target(da6d8a6) trend

@pmdartus pmdartus merged commit 90fb663 into master Feb 5, 2018
@pmdartus pmdartus deleted the pmdartus/fix-peer-dependency branch February 5, 2018 18:19
pmdartus pushed a commit that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants