Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): invert condition to apply click-event-composed polyfill #591

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

ekashida
Copy link
Member

(cherry picked from commit dc506e4)

Details

#590

Does this PR introduce a breaking change?

  • Yes
  • No

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: edb8276 | Target commit: 0591210

lwc-engine-benchmark

table-append-1k metric base(edb8276) target(0591210) trend
benchmark-table/append/1k duration 145.60 (± 5.50 ms) 144.20 (± 5.20 ms) 0.96% 👌
table-clear-1k metric base(edb8276) target(0591210) trend
benchmark-table/clear/1k duration 11.15 (± 0.60 ms) 11.30 (± 0.80 ms) -1.35% 👌
table-create-10k metric base(edb8276) target(0591210) trend
benchmark-table/create/10k duration 844.60 (± 8.70 ms) 841.30 (± 5.00 ms) 0.39% 👌
table-create-1k metric base(edb8276) target(0591210) trend
benchmark-table/create/1k duration 103.00 (± 1.80 ms) 104.10 (± 1.70 ms) -1.07% 👌
table-update-10th-1k metric base(edb8276) target(0591210) trend
benchmark-table/update-10th/1k duration 84.90 (± 2.80 ms) 84.80 (± 3.70 ms) 0.12% 👌
tablecmp-append-1k metric base(edb8276) target(0591210) trend
benchmark-table-component/append/1k duration 220.10 (± 3.90 ms) 215.40 (± 4.60 ms) 2.14% 👍
tablecmp-clear-1k metric base(edb8276) target(0591210) trend
benchmark-table-component/clear/1k duration 33.55 (± 1.75 ms) 33.60 (± 2.00 ms) -0.15% 👌
tablecmp-create-10k metric base(edb8276) target(0591210) trend
benchmark-table-component/create/10k duration 1511.40 (± 11.60 ms) 1494.20 (± 9.40 ms) 1.14% 👍
tablecmp-create-1k metric base(edb8276) target(0591210) trend
benchmark-table-component/create/1k duration 170.70 (± 3.30 ms) 171.70 (± 3.80 ms) -0.59% 👌
tablecmp-update-10th-1k metric base(edb8276) target(0591210) trend
benchmark-table-component/update-10th/1k duration 77.40 (± 4.20 ms) 75.70 (± 3.00 ms) 2.20% 👌
wc-append-1k metric base(edb8276) target(0591210) trend
benchmark-table-wc/append/1k duration 260.80 (± 6.00 ms) 259.60 (± 6.60 ms) 0.46% 👌
wc-clear-1k metric base(edb8276) target(0591210) trend
benchmark-table-wc/clear/1k duration 33.60 (± 1.50 ms) 33.00 (± 0.90 ms) 1.79% 👌
wc-create-10k metric base(edb8276) target(0591210) trend
benchmark-table-wc/create/10k duration 1963.10 (± 10.80 ms) 1934.70 (± 7.60 ms) 1.45% 👍
wc-create-1k metric base(edb8276) target(0591210) trend
benchmark-table-wc/create/1k duration 208.45 (± 2.85 ms) 209.70 (± 4.70 ms) -0.60% 👌
wc-update-10th-1k metric base(edb8276) target(0591210) trend
benchmark-table-wc/update-10th/1k duration 73.90 (± 2.90 ms) 75.60 (± 4.50 ms) -2.30% 👌

@ekashida ekashida merged commit cb7c43a into master Aug 23, 2018
@ekashida ekashida deleted the cherry-590 branch August 23, 2018 02:32
@ekashida
Copy link
Member Author

@apapko approved over slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant