Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update package version when releasing #595

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

ekashida
Copy link
Member

Details

lerna changed behavior in 3.x to clean up after itself after publishing:
https://github.com/lerna/lerna/blob/3cbeeabcb443d9415bb86c4539652b85cd7b4025/commands/publish/index.js#L354-L363

Since we commit all the changes in a later stage, we need to invoke lerna version again after the publish to get all the version bumps back.

Will refactor later to use --amend so that we don't have to run lerna version twice.

Does this PR introduce a breaking change?

  • Yes
  • No

@ekashida ekashida force-pushed the ekashida/release-bump-versions branch from 9814959 to c94d795 Compare August 15, 2018 22:03
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 7739e64 | Target commit: c94d795

lwc-engine-benchmark

table-append-1k metric base(7739e64) target(c94d795) trend
benchmark-table/append/1k duration 154.60 (± 4.00 ms) 154.80 (± 5.70 ms) -0.13% 👌
table-clear-1k metric base(7739e64) target(c94d795) trend
benchmark-table/clear/1k duration 12.10 (± 0.70 ms) 11.90 (± 0.50 ms) 1.65% 👌
table-create-10k metric base(7739e64) target(c94d795) trend
benchmark-table/create/10k duration 878.80 (± 5.00 ms) 876.90 (± 5.30 ms) 0.22% 👌
table-create-1k metric base(7739e64) target(c94d795) trend
benchmark-table/create/1k duration 106.50 (± 1.70 ms) 107.10 (± 1.50 ms) -0.56% 👌
table-update-10th-1k metric base(7739e64) target(c94d795) trend
benchmark-table/update-10th/1k duration 88.10 (± 4.20 ms) 93.90 (± 5.20 ms) -6.58% 👎
tablecmp-append-1k metric base(7739e64) target(c94d795) trend
benchmark-table-component/append/1k duration 232.40 (± 5.10 ms) 233.30 (± 4.10 ms) -0.39% 👌
tablecmp-clear-1k metric base(7739e64) target(c94d795) trend
benchmark-table-component/clear/1k duration 37.25 (± 1.70 ms) 37.50 (± 1.70 ms) -0.67% 👌
tablecmp-create-10k metric base(7739e64) target(c94d795) trend
benchmark-table-component/create/10k duration 1555.50 (± 5.60 ms) 1587.10 (± 7.10 ms) -2.03% 👎
tablecmp-create-1k metric base(7739e64) target(c94d795) trend
benchmark-table-component/create/1k duration 176.50 (± 4.10 ms) 179.20 (± 5.00 ms) -1.53% 👎
tablecmp-update-10th-1k metric base(7739e64) target(c94d795) trend
benchmark-table-component/update-10th/1k duration 80.60 (± 4.40 ms) 78.00 (± 5.50 ms) 3.23% 👌
wc-append-1k metric base(7739e64) target(c94d795) trend
benchmark-table-wc/append/1k duration 274.30 (± 6.00 ms) 266.50 (± 9.50 ms) 2.84% 👍
wc-clear-1k metric base(7739e64) target(c94d795) trend
benchmark-table-wc/clear/1k duration 36.20 (± 1.15 ms) 36.40 (± 1.30 ms) -0.55% 👌
wc-create-10k metric base(7739e64) target(c94d795) trend
benchmark-table-wc/create/10k duration 2024.50 (± 10.00 ms) 2023.10 (± 11.80 ms) 0.07% 👌
wc-create-1k metric base(7739e64) target(c94d795) trend
benchmark-table-wc/create/1k duration 218.00 (± 4.20 ms) 217.40 (± 4.00 ms) 0.28% 👌
wc-update-10th-1k metric base(7739e64) target(c94d795) trend
benchmark-table-wc/update-10th/1k duration 76.80 (± 4.10 ms) 77.90 (± 4.40 ms) -1.43% 👌

@ekashida ekashida requested a review from byao August 16, 2018 01:25
@byao byao merged commit ea0434d into master Aug 16, 2018
@byao
Copy link
Contributor

byao commented Aug 16, 2018

@ekashida please create 216/patch cp PR

ekashida added a commit that referenced this pull request Aug 17, 2018
@ekashida ekashida deleted the ekashida/release-bump-versions branch September 27, 2018 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants