Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): using tabindex getter in assert #785

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

davidturissini
Copy link
Contributor

Details

Using native tabindex getter instead of elm.tabIndex

Does this PR introduce a breaking change?

  • Yes
  • No

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: a5689a5 | Target commit: 19959fc

lwc-engine-benchmark

table-append-1k metric base(a5689a5) target(19959fc) trend
benchmark-table/append/1k duration 149.40 (±4.25 ms) 149.75 (±3.90 ms) +0.4ms (0.2%) 👌
table-clear-1k metric base(a5689a5) target(19959fc) trend
benchmark-table/clear/1k duration 6.30 (±0.40 ms) 6.20 (±0.40 ms) -0.1ms (1.6%) 👌
table-create-10k metric base(a5689a5) target(19959fc) trend
benchmark-table/create/10k duration 870.55 (±6.05 ms) 856.95 (±4.40 ms) -13.6ms (1.6%) 👍
table-create-1k metric base(a5689a5) target(19959fc) trend
benchmark-table/create/1k duration 113.50 (±2.80 ms) 115.35 (±3.70 ms) +1.8ms (1.6%) 👎
table-update-10th-1k metric base(a5689a5) target(19959fc) trend
benchmark-table/update-10th/1k duration 74.30 (±1.65 ms) 86.05 (±1.65 ms) +11.8ms (15.8%) 👎
tablecmp-append-1k metric base(a5689a5) target(19959fc) trend
benchmark-table-component/append/1k duration 237.90 (±9.80 ms) 237.25 (±11.95 ms) -0.7ms (0.3%) 👌
tablecmp-clear-1k metric base(a5689a5) target(19959fc) trend
benchmark-table-component/clear/1k duration 12.10 (±1.40 ms) 11.65 (±1.55 ms) -0.5ms (3.7%) 👌
tablecmp-create-10k metric base(a5689a5) target(19959fc) trend
benchmark-table-component/create/10k duration 1633.10 (±9.55 ms) 1639.80 (±10.80 ms) +6.7ms (0.4%) 👌
tablecmp-create-1k metric base(a5689a5) target(19959fc) trend
benchmark-table-component/create/1k duration 202.00 (±4.70 ms) 199.30 (±5.75 ms) -2.7ms (1.3%) 👌
tablecmp-update-10th-1k metric base(a5689a5) target(19959fc) trend
benchmark-table-component/update-10th/1k duration 69.40 (±5.95 ms) 69.70 (±5.00 ms) +0.3ms (0.4%) 👌
wc-append-1k metric base(a5689a5) target(19959fc) trend
benchmark-table-wc/append/1k duration 229.50 (±11.80 ms) 233.05 (±9.60 ms) +3.6ms (1.5%) 👌
wc-clear-1k metric base(a5689a5) target(19959fc) trend
benchmark-table-wc/clear/1k duration 23.25 (±1.70 ms) 22.15 (±2.45 ms) -1.1ms (4.7%) 👌
wc-create-10k metric base(a5689a5) target(19959fc) trend
benchmark-table-wc/create/10k duration 1690.80 (±45.70 ms) 1694.70 (±26.75 ms) +3.9ms (0.2%) 👌
wc-create-1k metric base(a5689a5) target(19959fc) trend
benchmark-table-wc/create/1k duration 203.05 (±6.15 ms) 201.30 (±4.35 ms) -1.8ms (0.9%) 👌
wc-update-10th-1k metric base(a5689a5) target(19959fc) trend
benchmark-table-wc/update-10th/1k duration 70.10 (±4.85 ms) 70.80 (±5.45 ms) +0.7ms (1.0%) 👌

@davidturissini davidturissini merged commit e56b4e2 into master Oct 30, 2018
@davidturissini davidturissini deleted the dturissini/api-tab-index-0 branch October 30, 2018 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants