fix: import inline styles #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmdartus
reviewed
Nov 16, 2018
| buffer += ` };\n`; | ||
| buffer += `}`; | ||
| buffer += 'if (_implicitStylesheets) {\n'; | ||
| buffer += ` tmpl.stylesheets ? tmpl.stylesheets.push(_implicitStylesheets) : tmpl.stylesheets = [_implicitStylesheets]\n`; |
There was a problem hiding this comment.
Instead of adding that here, what about always adding the stylesheet property in the produced template to avoid the branching here?
| buffer += ` tmpl.stylesheets ? tmpl.stylesheets.push(_implicitStylesheets) : tmpl.stylesheets = [_implicitStylesheets]\n`; | ||
| buffer += `}\n`; | ||
|
|
||
| buffer += `tmpl.stylesheetTokens = {\n`; |
There was a problem hiding this comment.
Why isn't the template compiler in charge of attaching those properties? Why should it be the compiler?
There was a problem hiding this comment.
I haven't change the attaching on the properties...
A it can' because the implicit css we already had.
| @@ -101,28 +82,24 @@ export function resetStyleAttributes(vm: VM): void { | |||
| /** | |||
| * Apply/Update the styling token applied to the host element. | |||
| */ | |||
| export function applyStyleAttributes(vm: VM, stylesheet: Stylesheet): void { | |||
| export function applyStyleAttributes(vm: VM, hostAttribute, shadowAttribute): void { | |||
diervo
force-pushed
the
dval/fixInlineStyles
branch
from
8f2511b
to
506bc50
Compare
before the output didnt include:
tmpl.stylesheets = [];
tmpl.stylesheetTokens = {
hostAttribute: "x-foo_foo-host",
shadowAttribute: "x-foo_foo"
};
|
@diervo fixed the sourcemap test, was failing cause of a shift (5 lines). |
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
caridy
approved these changes
Nov 19, 2018
Benchmark resultsBase commit: lwc-engine-benchmark
|
|
Merging since all compat failures are flappers... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Allow import for inline styles.