Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(engine): add global events test #961

Closed
wants to merge 2 commits into from

Conversation

apapko
Copy link
Collaborator

@apapko apapko commented Jan 15, 2019

Details

This PR is ONLY a test coverage for global component event bubbling issue #960 and to be merged into @caridy 's fix.

NOTE: the CI will fail until Caridy's fix is introduced.

Does this PR introduce a breaking change?

  • Yes
  • No

@apapko apapko requested a review from caridy January 15, 2019 00:23
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 14d169b | Target commit: 766a485

lwc-engine-benchmark

table-append-1k metric base(14d169b) target(766a485) trend
benchmark-table/append/1k duration 151.10 (±5.30 ms) 151.95 (±4.80 ms) +0.8ms (0.6%) 👌
table-clear-1k metric base(14d169b) target(766a485) trend
benchmark-table/clear/1k duration 6.10 (±0.40 ms) 6.00 (±0.40 ms) -0.1ms (1.6%) 👌
table-create-10k metric base(14d169b) target(766a485) trend
benchmark-table/create/10k duration 912.15 (±6.35 ms) 923.25 (±9.15 ms) +11.1ms (1.2%) 👎
table-create-1k metric base(14d169b) target(766a485) trend
benchmark-table/create/1k duration 119.85 (±2.75 ms) 122.05 (±3.00 ms) +2.2ms (1.8%) 👎
table-update-10th-1k metric base(14d169b) target(766a485) trend
benchmark-table/update-10th/1k duration 76.60 (±2.95 ms) 86.70 (±2.25 ms) +10.1ms (13.2%) 👎
tablecmp-append-1k metric base(14d169b) target(766a485) trend
benchmark-table-component/append/1k duration 251.75 (±8.00 ms) 253.95 (±5.85 ms) +2.2ms (0.9%) 👌
tablecmp-clear-1k metric base(14d169b) target(766a485) trend
benchmark-table-component/clear/1k duration 11.85 (±1.40 ms) 11.80 (±1.50 ms) -0.1ms (0.4%) 👌
tablecmp-create-10k metric base(14d169b) target(766a485) trend
benchmark-table-component/create/10k duration 1762.50 (±28.85 ms) 1769.10 (±24.80 ms) +6.6ms (0.4%) 👌
tablecmp-create-1k metric base(14d169b) target(766a485) trend
benchmark-table-component/create/1k duration 211.10 (±6.05 ms) 216.80 (±6.20 ms) +5.7ms (2.7%) 👎
tablecmp-update-10th-1k metric base(14d169b) target(766a485) trend
benchmark-table-component/update-10th/1k duration 71.30 (±5.75 ms) 75.15 (±4.90 ms) +3.9ms (5.4%) 👎
wc-append-1k metric base(14d169b) target(766a485) trend
benchmark-table-wc/append/1k duration 258.60 (±4.05 ms) 259.85 (±5.65 ms) +1.3ms (0.5%) 👌
wc-clear-1k metric base(14d169b) target(766a485) trend
benchmark-table-wc/clear/1k duration 23.65 (±2.45 ms) 22.35 (±1.90 ms) -1.3ms (5.5%) 👌
wc-create-10k metric base(14d169b) target(766a485) trend
benchmark-table-wc/create/10k duration 1991.60 (±11.35 ms) 2028.95 (±15.40 ms) +37.3ms (1.9%) 👎
wc-create-1k metric base(14d169b) target(766a485) trend
benchmark-table-wc/create/1k duration 229.30 (±5.75 ms) 226.05 (±5.55 ms) -3.3ms (1.4%) 👌
wc-update-10th-1k metric base(14d169b) target(766a485) trend
benchmark-table-wc/update-10th/1k duration 72.15 (±5.40 ms) 73.85 (±5.50 ms) +1.7ms (2.4%) 👌

@caridy
Copy link
Contributor

caridy commented Jan 18, 2019

this will require a lot more work to move more logic into this polyfill from the synthetic shadow, it will take a while to fix. This is a very narrow problem since the events must be non-composed, but still we need to fix it. Also, all these tests are dispatching events on the root element, which are technically accessible at the window level, the error that we want to fix is when the event is actually dispatched from within a shadow.

@apapko
Copy link
Collaborator Author

apapko commented Feb 6, 2019

@caridy looks like we don't need this? Can we close it?

@caridy
Copy link
Contributor

caridy commented Feb 6, 2019

Keep it open for now.

@pmdartus
Copy link
Member

@apapko I am currently migrating all the event tests over to Karma. I added a test for this issue in #1114. I think we can close this PR for now.

@apapko
Copy link
Collaborator Author

apapko commented Mar 25, 2019

Thank you!

@apapko apapko closed this Mar 25, 2019
@apapko apapko deleted the apapko/global-events-coverage branch March 25, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants