-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document.all seems leaked directly to the iframe #76
Comments
Oh wow, that’s unexpected: document.all == null
> true
document.all.length
> 1352 I wonder why, and what other APIs are implementing a similar magical behavior. As for the fix, it should be an easy one. |
caridy
added a commit
that referenced
this issue
Mar 16, 2020
1 task
caridy
added a commit
that referenced
this issue
Mar 17, 2020
fixes #76: document.all == null breaks the membrane for valid targets
once again @mmis1000, thanks for the help here, you rock! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Because
document.all == null
https://github.com/caridy/secure-javascript-environment/blob/6032355e5d26f70effa7cdb3cf6db2e051d81c54/src/secure-value.ts#L111
This line is incorrect because it will include
document.all
The text was updated successfully, but these errors were encountered: