Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document.all seems leaked directly to the iframe #76

Closed
mmis1000 opened this issue Mar 15, 2020 · 2 comments · Fixed by #77
Closed

document.all seems leaked directly to the iframe #76

mmis1000 opened this issue Mar 15, 2020 · 2 comments · Fixed by #77

Comments

@mmis1000
Copy link

mmis1000 commented Mar 15, 2020

Because document.all == null

https://github.com/caridy/secure-javascript-environment/blob/6032355e5d26f70effa7cdb3cf6db2e051d81c54/src/secure-value.ts#L111

This line is incorrect because it will include document.all

@caridy
Copy link
Contributor

caridy commented Mar 16, 2020

Oh wow, that’s unexpected:

document.all == null
> true
document.all.length
> 1352

I wonder why, and what other APIs are implementing a similar magical behavior.

As for the fix, it should be an easy one.

caridy added a commit that referenced this issue Mar 17, 2020
fixes #76: document.all == null breaks the membrane for valid targets
@caridy
Copy link
Contributor

caridy commented Mar 18, 2020

once again @mmis1000, thanks for the help here, you rock!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants