Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prettier for code formatting #116

Closed
pmdartus opened this issue Nov 21, 2019 · 2 comments · Fixed by #135
Closed

Add prettier for code formatting #116

pmdartus opened this issue Nov 21, 2019 · 2 comments · Fixed by #135
Labels
enhancement New feature or request

Comments

@pmdartus
Copy link
Member

Description

Currently there is no code formatting tool integrated with this repository. In order to ensure consistent code style, it would be great to add prettier to the repository and run it:

  • on the local dev machine: using a pre-commit hook
  • on the CI: to enforce code styling
@pmdartus pmdartus mentioned this issue Nov 21, 2019
Closed
@pmdartus pmdartus added the enhancement New feature or request label Nov 21, 2019
@trevor-bliss
Copy link
Contributor

Anxiously awaiting your PR @pmdartus :)

@pmdartus pmdartus mentioned this issue Mar 3, 2020
Merged
@pmdartus
Copy link
Member Author

pmdartus commented Mar 3, 2020

I am now anxiously waiting for the PR to be reviewed 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add code formatting and linting on all files salesforce/sfdx-lwc-jest
2 participants
@trevor-bliss @pmdartus