Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code formatting and linting on all files #135

Merged
merged 3 commits into from
Mar 3, 2020
Merged

Add code formatting and linting on all files #135

merged 3 commits into from
Mar 3, 2020

Conversation

pmdartus
Copy link
Member

@pmdartus pmdartus commented Mar 3, 2020

Changes

  • Add prettier.
  • Add pre-commit hook for linting and code formatting.
  • Enable linting on all the components under the src/lightning-stubs folder.
  • Fix existing linting issues.

Fixes #116.

ravijayaramappa
ravijayaramappa reviewed Mar 3, 2020
View reviewed changes
.prettierrc
"tabWidth": 4,
"singleQuote": true,
"trailingComma": "all"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

@trevor-bliss trevor-bliss merged commit 93b6855 into master Mar 3, 2020
@trevor-bliss trevor-bliss deleted the pmdartus/add-prettier branch March 3, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravijayaramappa ravijayaramappa ravijayaramappa approved these changes

@trevor-bliss trevor-bliss trevor-bliss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add prettier for code formatting
3 participants
@pmdartus @ravijayaramappa @trevor-bliss