fix(scripts): why do many upgrade when one upgrade do trick? #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjhsf
commented
Jun 28, 2024
| yarn upgrade \ | ||
| @lwc/compiler@$LWC_VERSION \ | ||
| @lwc/engine-dom@$LWC_VERSION \ | ||
| @lwc/engine-server@$LWC_VERSION \ |
There was a problem hiding this comment.
Note this addition! It seems to have been added as a dep after this file was created, but never added here.
nolanlawson
approved these changes
Jun 28, 2024
|
Technically this is a breaking change, since we're bumping lwc to v7. But that's fine. Eventually we should do #349 which would resolve that problem. |
I wasn't planning on doing a v7 bump; that must've snuck in there when I was testing the script. |
Merged
This was referenced Aug 28, 2024
Merged
This was referenced Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running 9
yarn upgradecommands takes 45 seconds on my machine, 36 if the packages are already at the target version.Running 1
yarn upgradecommands takes 15 seconds on my machine, 12 if the packages are already at the target version.