add implementation to getFieldValue #83
Conversation
|
@kevinv11n I updated the stub here to use the real impl. Also added the impl for |
| * @return The object and field API names. | ||
| */ | ||
| function splitQualifiedFieldApiName(fieldApiName) { | ||
| const idx = fieldApiName.indexOf("."); |
There was a problem hiding this comment.
consider adding existence check prior invoking indexOf
| /** | ||
| * Split the object API name and field API name from a qualified field name. | ||
| * Eg: Opportunity.Title returns ['Opportunity', 'Title'] | ||
| * Eg: Opportunity.Account.Name returns ['Opportunity', 'Account.Name'] |
| // object api name must non-empty | ||
| throw new TypeError("Value does not include an object API name."); | ||
| } | ||
| return [fieldApiName.substring(0, idx), fieldApiName.substring(idx + 1)]; |
There was a problem hiding this comment.
what about returning an object with apiName and fieldName instead of an array? This way you don't have to worry about the order and the readability will be more straight forward
| const idx = fieldApiName.indexOf("."); | ||
| if (idx < 1) { | ||
| // object api name must non-empty | ||
| throw new TypeError("Value does not include an object API name."); |
There was a problem hiding this comment.
you should include the fieldApiName in the error message
| if (fvr === undefined) { | ||
| return undefined; | ||
| } | ||
| else { |
There was a problem hiding this comment.
is else purposely on a new line?
if () {
...
} else {
...
}| * @return The qualified field API name. | ||
| */ | ||
| function getFieldApiName(value) { | ||
| if (typeof value === "string") { |
There was a problem hiding this comment.
do we care about an empty string here?
| else if (value && typeof value.objectApiName === "string" && typeof value.fieldApiName === "string") { | ||
| return value.objectApiName + "." + value.fieldApiName; | ||
| } | ||
| throw new TypeError("Value is not a string or FieldId."); |
There was a problem hiding this comment.
include the value in the error message
|
@apapko I should have made this more clear in the PR description but this is code from the actual implementation of these stubbed out methods. I don't want to tweak it in minor ways. We should keep it a straight copy/paste so if the real impl gets updated we can update the code here trivially. |
Fixes #79