Avoid using `arguments` #316

wjhsf · 2023-10-27T19:49:08Z

Using arguments is a known code smell. It is used by createPromiseCallback to extract the callback from the last provided argument. However, all calling code already knows which variable contains the callback, so we don't actually need to use arguments.

tsconfig.json

lib/utils.ts

lib/memstore.ts

lib/__tests__/removeAll.spec.ts

lib/cookie/cookieJar.ts

This reverts commit f2df0bb.

awaterma

Approved.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tough-cookie](https://togithub.com/salesforce/tough-cookie) | devDependencies | major | [`^4.1.4` -> `^5.0.0`](https://renovatebot.com/diffs/npm/tough-cookie/4.1.4/5.0.0) | --- ### Release Notes <details> <summary>salesforce/tough-cookie (tough-cookie)</summary> ### [`v5.0.0`](https://togithub.com/salesforce/tough-cookie/releases/tag/v5.0.0) [Compare Source](https://togithub.com/salesforce/tough-cookie/compare/v4.1.4...v5.0.0) #### Summary ##### Breaking Changes - We've migrated the project to TypeScript! First-party types are now available. - The minimum supported version of node is v18. - We no longer provide official support for non-node enviroments. ##### API Changes - We've standardized most of our exposed interfaces to accept both `null` and `undefined` and return only `undefined`. - `getCookie` and `getCookies` now accept a `string` or `URL` as a parameter. - We've removed the `inspect` function in favor of node's `util.inspect.custom` symbol. Cookies may appear different when logged in non-node environments. ##### Other Changes - Fixed the expiry time not updating when a cookie is updating. - Fixed validation errors not getting called in some callbacks. - [New documentation](https://togithub.com/salesforce/tough-cookie/blob/v5.0.0/api/docs/tough-cookie.md) that is always kept up to date! - Performance improvements. #### What's Changed - Typescript support by [@colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#264 - \[v5] Update config by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#269 - Fix prettier in eslint config by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#274 - Updated dev tooling by [@colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#271 - Port 283 fix to v5 by [@colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#287 - Remove some [@ts-ignore](https://togithub.com/ts-ignore) directives. by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#288 - Clean up validate function. by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#275 - Changes to support full eslint rule configurations by [@colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#289 - Split giant cookie.ts into multiple files. by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#296 - Merge branch 'master' into v5 by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#300 - Merge `v5` into `master` by [@colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#303 - Preparing for release `5.0.0-rc.0` by [@colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#304 - Bump [@babel/traverse](https://togithub.com/babel/traverse) from 7.21.3 to 7.23.2 by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#305 - Configure dependabot and codeowners by [@colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#306 - Bump [@typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) from 5.58.0 to 5.62.0 by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#310 - Bump eslint-config-prettier from 8.8.0 to 9.0.0 by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#311 - Bump async from 2.6.4 to 3.2.4 by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#313 - Avoid using `arguments` by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#316 - Configure dependabot to ignore [@types/node](https://togithub.com/types/node). by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#319 - Bump dependencies. by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#323 - Bump the dev-dependencies group with 6 updates by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#342 - Bump the dev-dependencies group with 1 update by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#344 - Bump the dev-dependencies group with 3 updates by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#347 - docs: use correct memstore file link by [@alissonsleal](https://togithub.com/alissonsleal) in [salesforce/tough-cookie#349 - Bump the dev-dependencies group with 3 updates by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#351 - Bump the dev-dependencies group with 2 updates by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#354 - Fix expiry time not updating when cookie is updated by [@colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#345 - Change dependabot to monthly by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#355 - Bump the dev-dependencies group with 5 updates by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#358 - Avoid `void` by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#331 - Replace `psl` with `tldts` by [@colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#346 - Bump the production-dependencies group with 1 update by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#362 - Bump the dev-dependencies group with 4 updates by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#363 - docs: fix JSON.serialize -> JSON.stringify by [@zavan](https://togithub.com/zavan) in [salesforce/tough-cookie#361 - Remove workarounds for `util` in non-node environments by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#359 - Accept URL parameter in `getCookies` and `setCookie` by [@colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#364 - Remove community cookie store links by [@colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#367 - Handle unlikely edge case in unimportant util by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#366 - Fix allow listed `files` for what to include in npm package by [@colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#368 - fix [#256](https://togithub.com/salesforce/tough-cookie/issues/256) by [@hrueger](https://togithub.com/hrueger) in [salesforce/tough-cookie#297 - Preparing for release 5.0.0-rc.1 by [@colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#369 - Bump [@typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) from 6.20.0 to 7.0.0 by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#373 - Bump the production-dependencies group with 1 update by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#370 - Fixes eslint plugin dev upgrades by [@colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#375 - restore `parse` export that was accidentally removed by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#376 - Clean up cookie creation by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#381 - Enforce explicit function return type by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#383 - patch removed util methods for vows by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#389 - clean up usage of null/undefined by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#380 - Bump the dev-dependencies group with 2 updates by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#404 - Bump the production-dependencies group with 1 update by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#403 - Remove `@types/psl` from dev dependencies by [@colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#406 - Bump tldts from 6.1.16 to 6.1.18 in the production-dependencies group by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#411 - Bump the dev-dependencies group with 2 updates by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#412 - Bump ejs from 3.1.9 to 3.1.10 by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#413 - Update v5 docs by [@colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#384 - Enable strict type checked rules by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#392 - Preparing for release 5.0.0-rc.2 by [@colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#414 - Bump the dev-dependencies group with 4 updates by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#417 - Bump [@eslint/js](https://togithub.com/eslint/js) from 8.57.0 to 9.4.0 by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#419 - Bump tldts from 6.1.18 to 6.1.24 in the production-dependencies group across 1 directory by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#420 - chore: update deps by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#421 - Use latest TypeScript version by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#423 - Update contributors by [@colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#425 - Bump tldts from 6.1.28 to 6.1.30 in the production-dependencies group by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#426 - Bump the dev-dependencies group with 4 updates by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#427 - Fix validation errors not calling callbacks by [@colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#424 - Preparing for release 5.0.0-rc.3 by [@colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#430 - Remove url-parse and punycode by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#429 - Checks structure instead of instanceof for URL test by [@colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#431 - pre-release cleanup by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#428 - Preparing for release 5.0.0-rc.4 by [@colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#432 - use `domainToASCII(str)` instead of `new URL(str).hostName` by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#433 - Bump tldts from 6.1.32 to 6.1.37 in the production-dependencies group by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#436 - Bump the dev-dependencies group across 1 directory with 6 updates by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#439 - Bump tldts from 6.1.37 to 6.1.41 in the production-dependencies group by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#443 - Bump the dev-dependencies group with 6 updates by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#444 - upgrade typescript-eslint to 8.0.1 by [@wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#440 - Bump the dev-dependencies group with 2 updates by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#448 - Bump eslint from 8.57.0 to 9.9.1 by [@dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#449 - Prepare v5 by [@colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#451 #### New Contributors - [@alissonsleal](https://togithub.com/alissonsleal) made their first contribution in [salesforce/tough-cookie#349 - [@zavan](https://togithub.com/zavan) made their first contribution in [salesforce/tough-cookie#361 - [@hrueger](https://togithub.com/hrueger) made their first contribution in [salesforce/tough-cookie#297 **Full Changelog**: salesforce/tough-cookie@v4.1.3...v5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tough-cookie](https://togithub.com/salesforce/tough-cookie) | devDependencies | major | [`^4.1.4` -> `^5.0.0`](https://renovatebot.com/diffs/npm/tough-cookie/4.1.4/5.0.0) | --- ### Release Notes <details> <summary>salesforce/tough-cookie (tough-cookie)</summary> ### [`v5.0.0`](https://togithub.com/salesforce/tough-cookie/releases/tag/v5.0.0) [Compare Source](https://togithub.com/salesforce/tough-cookie/compare/v4.1.4...v5.0.0) #### Summary ##### Breaking Changes - We've migrated the project to TypeScript! First-party types are now available. - The minimum supported version of node is v18. - We no longer provide official support for non-node enviroments. ##### API Changes - We've standardized most of our exposed interfaces to accept both `null` and `undefined` and return only `undefined`. - `getCookie` and `getCookies` now accept a `string` or `URL` as a parameter. - We've removed the `inspect` function in favor of node's `util.inspect.custom` symbol. Cookies may appear different when logged in non-node environments. ##### Other Changes - Fixed the expiry time not updating when a cookie is updating. - Fixed validation errors not getting called in some callbacks. - [New documentation](https://togithub.com/salesforce/tough-cookie/blob/v5.0.0/api/docs/tough-cookie.md) that is always kept up to date! - Performance improvements. #### What's Changed - Typescript support by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#264 - \[v5] Update config by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#269 - Fix prettier in eslint config by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#274 - Updated dev tooling by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#271 - Port 283 fix to v5 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#287 - Remove some [@&elastic#8203;ts-ignore](https://togithub.com/ts-ignore) directives. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#288 - Clean up validate function. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#275 - Changes to support full eslint rule configurations by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#289 - Split giant cookie.ts into multiple files. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#296 - Merge branch 'master' into v5 by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#300 - Merge `v5` into `master` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#303 - Preparing for release `5.0.0-rc.0` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#304 - Bump [@&elastic#8203;babel/traverse](https://togithub.com/babel/traverse) from 7.21.3 to 7.23.2 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#305 - Configure dependabot and codeowners by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#306 - Bump [@&elastic#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) from 5.58.0 to 5.62.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#310 - Bump eslint-config-prettier from 8.8.0 to 9.0.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#311 - Bump async from 2.6.4 to 3.2.4 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#313 - Avoid using `arguments` by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#316 - Configure dependabot to ignore [@&elastic#8203;types/node](https://togithub.com/types/node). by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#319 - Bump dependencies. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#323 - Bump the dev-dependencies group with 6 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#342 - Bump the dev-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#344 - Bump the dev-dependencies group with 3 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#347 - docs: use correct memstore file link by [@&elastic#8203;alissonsleal](https://togithub.com/alissonsleal) in [salesforce/tough-cookie#349 - Bump the dev-dependencies group with 3 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#351 - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#354 - Fix expiry time not updating when cookie is updated by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#345 - Change dependabot to monthly by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#355 - Bump the dev-dependencies group with 5 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#358 - Avoid `void` by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#331 - Replace `psl` with `tldts` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#346 - Bump the production-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#362 - Bump the dev-dependencies group with 4 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#363 - docs: fix JSON.serialize -> JSON.stringify by [@&elastic#8203;zavan](https://togithub.com/zavan) in [salesforce/tough-cookie#361 - Remove workarounds for `util` in non-node environments by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#359 - Accept URL parameter in `getCookies` and `setCookie` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#364 - Remove community cookie store links by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#367 - Handle unlikely edge case in unimportant util by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#366 - Fix allow listed `files` for what to include in npm package by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#368 - fix [#&elastic#8203;256](https://togithub.com/salesforce/tough-cookie/issues/256) by [@&elastic#8203;hrueger](https://togithub.com/hrueger) in [salesforce/tough-cookie#297 - Preparing for release 5.0.0-rc.1 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#369 - Bump [@&elastic#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) from 6.20.0 to 7.0.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#373 - Bump the production-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#370 - Fixes eslint plugin dev upgrades by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#375 - restore `parse` export that was accidentally removed by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#376 - Clean up cookie creation by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#381 - Enforce explicit function return type by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#383 - patch removed util methods for vows by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#389 - clean up usage of null/undefined by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#380 - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#404 - Bump the production-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#403 - Remove `@types/psl` from dev dependencies by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#406 - Bump tldts from 6.1.16 to 6.1.18 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#411 - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#412 - Bump ejs from 3.1.9 to 3.1.10 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#413 - Update v5 docs by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#384 - Enable strict type checked rules by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#392 - Preparing for release 5.0.0-rc.2 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#414 - Bump the dev-dependencies group with 4 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#417 - Bump [@&elastic#8203;eslint/js](https://togithub.com/eslint/js) from 8.57.0 to 9.4.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#419 - Bump tldts from 6.1.18 to 6.1.24 in the production-dependencies group across 1 directory by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#420 - chore: update deps by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#421 - Use latest TypeScript version by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#423 - Update contributors by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#425 - Bump tldts from 6.1.28 to 6.1.30 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#426 - Bump the dev-dependencies group with 4 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#427 - Fix validation errors not calling callbacks by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#424 - Preparing for release 5.0.0-rc.3 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#430 - Remove url-parse and punycode by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#429 - Checks structure instead of instanceof for URL test by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#431 - pre-release cleanup by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#428 - Preparing for release 5.0.0-rc.4 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#432 - use `domainToASCII(str)` instead of `new URL(str).hostName` by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#433 - Bump tldts from 6.1.32 to 6.1.37 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#436 - Bump the dev-dependencies group across 1 directory with 6 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#439 - Bump tldts from 6.1.37 to 6.1.41 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#443 - Bump the dev-dependencies group with 6 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#444 - upgrade typescript-eslint to 8.0.1 by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#440 - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#448 - Bump eslint from 8.57.0 to 9.9.1 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#449 - Prepare v5 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#451 #### New Contributors - [@&elastic#8203;alissonsleal](https://togithub.com/alissonsleal) made their first contribution in [salesforce/tough-cookie#349 - [@&elastic#8203;zavan](https://togithub.com/zavan) made their first contribution in [salesforce/tough-cookie#361 - [@&elastic#8203;hrueger](https://togithub.com/hrueger) made their first contribution in [salesforce/tough-cookie#297 **Full Changelog**: salesforce/tough-cookie@v4.1.3...v5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com> (cherry picked from commit f712e4a)

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tough-cookie](https://togithub.com/salesforce/tough-cookie) | devDependencies | major | [`^4.1.4` -> `^5.0.0`](https://renovatebot.com/diffs/npm/tough-cookie/4.1.4/5.0.0) | --- ### Release Notes <details> <summary>salesforce/tough-cookie (tough-cookie)</summary> ### [`v5.0.0`](https://togithub.com/salesforce/tough-cookie/releases/tag/v5.0.0) [Compare Source](https://togithub.com/salesforce/tough-cookie/compare/v4.1.4...v5.0.0) #### Summary ##### Breaking Changes - We've migrated the project to TypeScript! First-party types are now available. - The minimum supported version of node is v18. - We no longer provide official support for non-node enviroments. ##### API Changes - We've standardized most of our exposed interfaces to accept both `null` and `undefined` and return only `undefined`. - `getCookie` and `getCookies` now accept a `string` or `URL` as a parameter. - We've removed the `inspect` function in favor of node's `util.inspect.custom` symbol. Cookies may appear different when logged in non-node environments. ##### Other Changes - Fixed the expiry time not updating when a cookie is updating. - Fixed validation errors not getting called in some callbacks. - [New documentation](https://togithub.com/salesforce/tough-cookie/blob/v5.0.0/api/docs/tough-cookie.md) that is always kept up to date! - Performance improvements. #### What's Changed - Typescript support by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#264 - \[v5] Update config by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#269 - Fix prettier in eslint config by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#274 - Updated dev tooling by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#271 - Port 283 fix to v5 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#287 - Remove some [@&elastic#8203;ts-ignore](https://togithub.com/ts-ignore) directives. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#288 - Clean up validate function. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#275 - Changes to support full eslint rule configurations by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#289 - Split giant cookie.ts into multiple files. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#296 - Merge branch 'master' into v5 by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#300 - Merge `v5` into `master` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#303 - Preparing for release `5.0.0-rc.0` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#304 - Bump [@&elastic#8203;babel/traverse](https://togithub.com/babel/traverse) from 7.21.3 to 7.23.2 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#305 - Configure dependabot and codeowners by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#306 - Bump [@&elastic#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) from 5.58.0 to 5.62.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#310 - Bump eslint-config-prettier from 8.8.0 to 9.0.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#311 - Bump async from 2.6.4 to 3.2.4 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#313 - Avoid using `arguments` by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#316 - Configure dependabot to ignore [@&elastic#8203;types/node](https://togithub.com/types/node). by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#319 - Bump dependencies. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#323 - Bump the dev-dependencies group with 6 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#342 - Bump the dev-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#344 - Bump the dev-dependencies group with 3 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#347 - docs: use correct memstore file link by [@&elastic#8203;alissonsleal](https://togithub.com/alissonsleal) in [salesforce/tough-cookie#349 - Bump the dev-dependencies group with 3 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#351 - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#354 - Fix expiry time not updating when cookie is updated by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#345 - Change dependabot to monthly by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#355 - Bump the dev-dependencies group with 5 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#358 - Avoid `void` by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#331 - Replace `psl` with `tldts` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#346 - Bump the production-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#362 - Bump the dev-dependencies group with 4 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#363 - docs: fix JSON.serialize -> JSON.stringify by [@&elastic#8203;zavan](https://togithub.com/zavan) in [salesforce/tough-cookie#361 - Remove workarounds for `util` in non-node environments by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#359 - Accept URL parameter in `getCookies` and `setCookie` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#364 - Remove community cookie store links by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#367 - Handle unlikely edge case in unimportant util by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#366 - Fix allow listed `files` for what to include in npm package by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#368 - fix [#&elastic#8203;256](https://togithub.com/salesforce/tough-cookie/issues/256) by [@&elastic#8203;hrueger](https://togithub.com/hrueger) in [salesforce/tough-cookie#297 - Preparing for release 5.0.0-rc.1 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#369 - Bump [@&elastic#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) from 6.20.0 to 7.0.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#373 - Bump the production-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#370 - Fixes eslint plugin dev upgrades by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#375 - restore `parse` export that was accidentally removed by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#376 - Clean up cookie creation by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#381 - Enforce explicit function return type by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#383 - patch removed util methods for vows by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#389 - clean up usage of null/undefined by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#380 - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#404 - Bump the production-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#403 - Remove `@types/psl` from dev dependencies by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#406 - Bump tldts from 6.1.16 to 6.1.18 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#411 - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#412 - Bump ejs from 3.1.9 to 3.1.10 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#413 - Update v5 docs by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#384 - Enable strict type checked rules by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#392 - Preparing for release 5.0.0-rc.2 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#414 - Bump the dev-dependencies group with 4 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#417 - Bump [@&elastic#8203;eslint/js](https://togithub.com/eslint/js) from 8.57.0 to 9.4.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#419 - Bump tldts from 6.1.18 to 6.1.24 in the production-dependencies group across 1 directory by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#420 - chore: update deps by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#421 - Use latest TypeScript version by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#423 - Update contributors by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#425 - Bump tldts from 6.1.28 to 6.1.30 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#426 - Bump the dev-dependencies group with 4 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#427 - Fix validation errors not calling callbacks by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#424 - Preparing for release 5.0.0-rc.3 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#430 - Remove url-parse and punycode by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#429 - Checks structure instead of instanceof for URL test by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#431 - pre-release cleanup by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#428 - Preparing for release 5.0.0-rc.4 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#432 - use `domainToASCII(str)` instead of `new URL(str).hostName` by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#433 - Bump tldts from 6.1.32 to 6.1.37 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#436 - Bump the dev-dependencies group across 1 directory with 6 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#439 - Bump tldts from 6.1.37 to 6.1.41 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#443 - Bump the dev-dependencies group with 6 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#444 - upgrade typescript-eslint to 8.0.1 by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#440 - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#448 - Bump eslint from 8.57.0 to 9.9.1 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#449 - Prepare v5 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#451 #### New Contributors - [@&elastic#8203;alissonsleal](https://togithub.com/alissonsleal) made their first contribution in [salesforce/tough-cookie#349 - [@&elastic#8203;zavan](https://togithub.com/zavan) made their first contribution in [salesforce/tough-cookie#361 - [@&elastic#8203;hrueger](https://togithub.com/hrueger) made their first contribution in [salesforce/tough-cookie#297 **Full Changelog**: salesforce/tough-cookie@v4.1.3...v5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com> (cherry picked from commit f712e4a) # Conflicts: # package.json # yarn.lock

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tough-cookie](https://togithub.com/salesforce/tough-cookie) | devDependencies | major | [`^4.1.4` -> `^5.0.0`](https://renovatebot.com/diffs/npm/tough-cookie/4.1.4/5.0.0) | --- ### Release Notes <details> <summary>salesforce/tough-cookie (tough-cookie)</summary> ### [`v5.0.0`](https://togithub.com/salesforce/tough-cookie/releases/tag/v5.0.0) [Compare Source](https://togithub.com/salesforce/tough-cookie/compare/v4.1.4...v5.0.0) #### Summary ##### Breaking Changes - We've migrated the project to TypeScript! First-party types are now available. - The minimum supported version of node is v18. - We no longer provide official support for non-node enviroments. ##### API Changes - We've standardized most of our exposed interfaces to accept both `null` and `undefined` and return only `undefined`. - `getCookie` and `getCookies` now accept a `string` or `URL` as a parameter. - We've removed the `inspect` function in favor of node's `util.inspect.custom` symbol. Cookies may appear different when logged in non-node environments. ##### Other Changes - Fixed the expiry time not updating when a cookie is updating. - Fixed validation errors not getting called in some callbacks. - [New documentation](https://togithub.com/salesforce/tough-cookie/blob/v5.0.0/api/docs/tough-cookie.md) that is always kept up to date! - Performance improvements. #### What's Changed - Typescript support by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#264 - \[v5] Update config by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#269 - Fix prettier in eslint config by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#274 - Updated dev tooling by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#271 - Port 283 fix to v5 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#287 - Remove some [@&elastic#8203;ts-ignore](https://togithub.com/ts-ignore) directives. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#288 - Clean up validate function. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#275 - Changes to support full eslint rule configurations by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#289 - Split giant cookie.ts into multiple files. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#296 - Merge branch 'master' into v5 by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#300 - Merge `v5` into `master` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#303 - Preparing for release `5.0.0-rc.0` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#304 - Bump [@&elastic#8203;babel/traverse](https://togithub.com/babel/traverse) from 7.21.3 to 7.23.2 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#305 - Configure dependabot and codeowners by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#306 - Bump [@&elastic#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) from 5.58.0 to 5.62.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#310 - Bump eslint-config-prettier from 8.8.0 to 9.0.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#311 - Bump async from 2.6.4 to 3.2.4 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#313 - Avoid using `arguments` by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#316 - Configure dependabot to ignore [@&elastic#8203;types/node](https://togithub.com/types/node). by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#319 - Bump dependencies. by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#323 - Bump the dev-dependencies group with 6 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#342 - Bump the dev-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#344 - Bump the dev-dependencies group with 3 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#347 - docs: use correct memstore file link by [@&elastic#8203;alissonsleal](https://togithub.com/alissonsleal) in [salesforce/tough-cookie#349 - Bump the dev-dependencies group with 3 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#351 - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#354 - Fix expiry time not updating when cookie is updated by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#345 - Change dependabot to monthly by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#355 - Bump the dev-dependencies group with 5 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#358 - Avoid `void` by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#331 - Replace `psl` with `tldts` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#346 - Bump the production-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#362 - Bump the dev-dependencies group with 4 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#363 - docs: fix JSON.serialize -> JSON.stringify by [@&elastic#8203;zavan](https://togithub.com/zavan) in [salesforce/tough-cookie#361 - Remove workarounds for `util` in non-node environments by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#359 - Accept URL parameter in `getCookies` and `setCookie` by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#364 - Remove community cookie store links by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#367 - Handle unlikely edge case in unimportant util by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#366 - Fix allow listed `files` for what to include in npm package by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#368 - fix [#&elastic#8203;256](https://togithub.com/salesforce/tough-cookie/issues/256) by [@&elastic#8203;hrueger](https://togithub.com/hrueger) in [salesforce/tough-cookie#297 - Preparing for release 5.0.0-rc.1 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#369 - Bump [@&elastic#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) from 6.20.0 to 7.0.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#373 - Bump the production-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#370 - Fixes eslint plugin dev upgrades by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#375 - restore `parse` export that was accidentally removed by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#376 - Clean up cookie creation by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#381 - Enforce explicit function return type by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#383 - patch removed util methods for vows by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#389 - clean up usage of null/undefined by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#380 - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#404 - Bump the production-dependencies group with 1 update by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#403 - Remove `@types/psl` from dev dependencies by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#406 - Bump tldts from 6.1.16 to 6.1.18 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#411 - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#412 - Bump ejs from 3.1.9 to 3.1.10 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#413 - Update v5 docs by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#384 - Enable strict type checked rules by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#392 - Preparing for release 5.0.0-rc.2 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#414 - Bump the dev-dependencies group with 4 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#417 - Bump [@&elastic#8203;eslint/js](https://togithub.com/eslint/js) from 8.57.0 to 9.4.0 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#419 - Bump tldts from 6.1.18 to 6.1.24 in the production-dependencies group across 1 directory by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#420 - chore: update deps by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#421 - Use latest TypeScript version by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#423 - Update contributors by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#425 - Bump tldts from 6.1.28 to 6.1.30 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#426 - Bump the dev-dependencies group with 4 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#427 - Fix validation errors not calling callbacks by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#424 - Preparing for release 5.0.0-rc.3 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#430 - Remove url-parse and punycode by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#429 - Checks structure instead of instanceof for URL test by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#431 - pre-release cleanup by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#428 - Preparing for release 5.0.0-rc.4 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#432 - use `domainToASCII(str)` instead of `new URL(str).hostName` by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#433 - Bump tldts from 6.1.32 to 6.1.37 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#436 - Bump the dev-dependencies group across 1 directory with 6 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#439 - Bump tldts from 6.1.37 to 6.1.41 in the production-dependencies group by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#443 - Bump the dev-dependencies group with 6 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#444 - upgrade typescript-eslint to 8.0.1 by [@&elastic#8203;wjhsf](https://togithub.com/wjhsf) in [salesforce/tough-cookie#440 - Bump the dev-dependencies group with 2 updates by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#448 - Bump eslint from 8.57.0 to 9.9.1 by [@&elastic#8203;dependabot](https://togithub.com/dependabot) in [salesforce/tough-cookie#449 - Prepare v5 by [@&elastic#8203;colincasey](https://togithub.com/colincasey) in [salesforce/tough-cookie#451 #### New Contributors - [@&elastic#8203;alissonsleal](https://togithub.com/alissonsleal) made their first contribution in [salesforce/tough-cookie#349 - [@&elastic#8203;zavan](https://togithub.com/zavan) made their first contribution in [salesforce/tough-cookie#361 - [@&elastic#8203;hrueger](https://togithub.com/hrueger) made their first contribution in [salesforce/tough-cookie#297 **Full Changelog**: salesforce/tough-cookie@v4.1.3...v5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>

wjhsf added 8 commits October 26, 2023 15:33

Ignore max-lines where appropriate.

2402513

Change callback error signature to null instead of undefined.

421b195

Remove unnecessary helper.

f2df0bb

Split error callback and success callback for better type narrowing.

ca0ec26

Be more strict about resolving/rejecting values.

d1b7446

Change promiseCallback to only accept a callback, not arguments.

1df12e9

Hide annoying warnings that pop up in IDE.

c216409

Handle different function signatures for callback argument.

0fec493

wjhsf requested review from awaterma and colincasey as code owners October 27, 2023 19:49

wjhsf added 2 commits October 27, 2023 15:52

Use more normal callback definition.

a7a84f3

Modern syntax!

7a24c79

wjhsf commented Oct 27, 2023

View reviewed changes

Revert "Remove unnecessary helper." Turns out it's necessary.

5220bf6

This reverts commit f2df0bb.

awaterma approved these changes Nov 3, 2023

View reviewed changes

wjhsf merged commit 25f9cb7 into master Nov 3, 2023
6 checks passed

wjhsf deleted the no-arguments branch November 3, 2023 16:23

kibanamachine mentioned this pull request Sep 18, 2024

[8.15] Update dependency tough-cookie to v5 (main) (#193107) elastic/kibana#193285

Open

kibanamachine mentioned this pull request Sep 18, 2024

[8.x] Update dependency tough-cookie to v5 (main) (#193107) elastic/kibana#193286

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid using `arguments` #316

Avoid using `arguments` #316

wjhsf commented Oct 27, 2023

awaterma left a comment

Avoid using arguments #316

Avoid using arguments #316

Conversation

wjhsf commented Oct 27, 2023

awaterma left a comment

Choose a reason for hiding this comment

Avoid using `arguments` #316

Avoid using `arguments` #316