Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid void #331

Merged
merged 6 commits into from
Jan 16, 2024
Merged

Avoid void #331

merged 6 commits into from
Jan 16, 2024

Commits on Nov 5, 2023

  1. Avoid using void.

    @wjhsf
    wjhsf committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    6056bbc View commit details
    Browse the repository at this point in the history

  2. Avoid using no-op callback. 

    Instead, change `putCookie` invocation depending on whether `callback` is provided.
    @wjhsf
    wjhsf committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    f5608fd View commit details
    Browse the repository at this point in the history

  3. Misc cleanup.

    @wjhsf
    wjhsf committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    030e176 View commit details
    Browse the repository at this point in the history

  4. Prefer promiseCallback.resolve where possible. 

    `promiseCallback.resolve()` is implemented as `cb(); return promise`,
so doing `promiseCallback.callback(); return promiseCallback.promise`
is unnecessary.
    @wjhsf
    wjhsf committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    09d2433 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Merge branch 'master' into avoid-void

    @colincasey
    colincasey authored Dec 8, 2023
    Configuration menu
    Copy the full SHA
    0945bfe View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Merge branch 'master' into avoid-void

    @wjhsf
    wjhsf authored Jan 16, 2024
    Configuration menu
    Copy the full SHA
    decbc1d View commit details
    Browse the repository at this point in the history