fix: always return stdout and stderr from execCmd #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@W-12556866@
mshanemc
approved these changes
Feb 16, 2023
| @@ -167,14 +167,13 @@ const execCmdSync = <T>(cmd: string, options?: ExecCmdOptions): ExecCmdResult<T> | |||
| const startTime = process.hrtime(); | |||
| const code = (shelljs.exec(`${cmd} 1> ${stdoutFile} 2> ${stderrFile} `, cmdOptions) as ShellString).code; | |||
|
|
|||
| if (code === 0) { | |||
There was a problem hiding this comment.
request, while you're here. Up on 158, can those fileLocations point to options.cwd so that stuff gets put in the sessionDir (which gets cleaned) instead of in the top of the project? I've seen that a few times, where if you ctrl-c the nut early you have to clean up files, gitignore them, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@W-12556866@
Found an instance where a plugin command finishes successfully, but needed results were capture on both stdout and stderr.
Modified execCmd to return both stdout and stderr regardless of command exit code.