Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the ability to override the default shell used by shelljs.exec #69

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented Apr 6, 2021

This adds the TESTKIT_EXEC_SHELL env var which allows tests to specify a shell other than the default used by shelljs, which is the same default as child_process. This shell will be used everywhere shelljs.exec() is called. It will still be possible to use the env var to override the shell but use a specific one when calling execCmd().

This affect:
execCmd()
TestSession setupCommands
TestProject creation with git clone or project:create

@W-8996057@

@shetzel shetzel requested a review from mshanemc April 6, 2021 22:44
@peternhale
Copy link
Contributor

@shetzel will there be a change to the orb to set the env var on windows VMs only?

@shetzel
Copy link
Contributor Author

shetzel commented Apr 7, 2021

@shetzel will there be a change to the orb to set the env var on windows VMs only?

If a different shell is needed per job then something in Circle CI config will need to change. Maybe that's the orb or maybe it's the project's circle config? I'm not sure.

@peternhale peternhale merged commit 02d09d0 into main Apr 27, 2021
@peternhale peternhale deleted the sh/TESTKIT_SHELL branch April 27, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants