Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add data bulk results #1097

Merged
merged 14 commits into from
Oct 30, 2024
Merged

feat: add data bulk results #1097

merged 14 commits into from
Oct 30, 2024

Conversation

cristiand391
Copy link
Member

@cristiand391 cristiand391 commented Oct 21, 2024

What does this PR do?

job completed, no failures:

Screenshot 2024-10-21 at 6 49 51 PM

job completed with 10 record failures:

Screenshot 2024-10-21 at 6 46 15 PM

job failure, no records processed.

Screenshot 2024-10-21 at 6 44 05 PM

aborted job, gets possible unprocessed records results

Screenshot 2024-10-21 at 6 48 09 PM

deprecations

sf data delete/upsert bulk had a --verbose flag that would print the job failures, this PR also deprecates it and points users to the new command:

sf data delete bulk
Screenshot 2024-10-24 at 1 07 04 PM

sf data upsert bulk
Screenshot 2024-10-24 at 1 07 25 PM

What issues does this PR fix or reference?

forcedotcom/cli#2387
@W-12408034@

@WillieRuemmele
Copy link
Contributor

QA Notes


✅ : in-progress error is nice and informative

 ➜  ../../oss/plugin-data/bin/run.js data bulk results -i 750D500000AsoUSIAZ
Status: InProgress
Operation: upsert
Object: Account

Processed records: 6800
Error (JobInProgressError): Job hasn't finished being processed yet.

✅ : success

Status: JobComplete
Operation: upsert
Object: Account

Processed records: 10000
Successful records: 10000

Saved successful results to 750D500000AsoUSIAZ-success-records.csv

✅ : failed records reported

Status: JobComplete
Operation: upsert
Object: Account

Processed records: 10015
Failed records: 1

Successful records: 10014

Saved successful results to 750D500000AsoUcIAJ-success-records.csv
Saved failed results to 750D500000AsoUcIAJ-failed-records.csv

@cristiand391 cristiand391 marked this pull request as ready for review October 21, 2024 21:50
@cristiand391 cristiand391 requested a review from a team as a code owner October 21, 2024 21:50
@WillieRuemmele
Copy link
Contributor

QA Notes (2)


✅ : flag deprecated

 ➜  ../../oss/plugin-data/bin/run.js data upsert bulk --external-id Id --sobject Account --file bulk --verbose 
Warning: The --verbose flag is deprecated and will be removed after March 2025, use "sf data bulk results" to get job results instead.

@WillieRuemmele WillieRuemmele merged commit 1113705 into main Oct 30, 2024
1 check passed
@WillieRuemmele WillieRuemmele deleted the cd/bulk-results branch October 30, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants