-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sh/display version in list #370
Conversation
const vDataMap: VersionDataMap = {}; | ||
versionData.map((vData) => { | ||
const version = getPackageVersionNumber(vData as PackagingSObjects.Package2Version, true); | ||
vDataMap[vData.Id] = { name: vData.Name, version }; | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should let you remove the internal type definition for VersionDataMap since the object type becomes inferable when you avoid mutating the empty object.
const vDataMap: VersionDataMap = {}; | |
versionData.map((vData) => { | |
const version = getPackageVersionNumber(vData as PackagingSObjects.Package2Version, true); | |
vDataMap[vData.Id] = { name: vData.Name, version }; | |
}); | |
const vDataMap = Object.fromEntries( | |
versionData.map((vData) => { | |
const version = getPackageVersionNumber(vData as PackagingSObjects.Package2Version, true); | |
return [vData.Id, { name: vData.Name, version }] | |
}); | |
) |
QA (using na40 hub) ✅ without verbose (no extra columns show up) |
NOTE: Requires this packaging library PR to merge before tests will pass.
What does this PR do?
Adds a
--verbose
flag to thepackage version create list
command that displays package name and version in the table results and the JSON.What issues does this PR fix or reference?
@W-13650725@
forcedotcom/cli#222