Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(perf): defer-app-insights #497

Merged
merged 9 commits into from
Aug 14, 2023
Merged

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Aug 11, 2023

requires forcedotcom/telemetry#274
that's published as a prerel 4.0.17-qa.0 and used in here. That needs to be removed before merging.

  1. consume the new standalone check from feat: standalone check for telemetry enabled forcedotcom/telemetry#274
  2. defer require of appInsights by putting it into a dynamic import inside the upload

side effects:

  1. use tsconfig module: node16 to consume those new exports

@W-13931049@

QA:
sf update qa

@mshanemc mshanemc changed the title Sm/defer-app-insights feat(perf): defer-app-insights Aug 11, 2023
@mshanemc mshanemc merged commit 9e42910 into sm/remove-vcs-check Aug 14, 2023
9 checks passed
@mshanemc mshanemc deleted the sm/defer-app-insights branch August 14, 2023 19:59
@mshanemc mshanemc restored the sm/defer-app-insights branch August 14, 2023 20:11
mshanemc added a commit that referenced this pull request Aug 14, 2023
* feat: remove vcs check

* feat(perf): defer-app-insights (#497)

* chore: use node16 modules for pjson exports

* chore: type only import

* feat: use standalone method

* perf: use standalone enabled check

* feat: dynamic import to defer require of appInsights

* test: config and stub change

* ci: use library pre-rel

* chore(release): 2.2.7-qa.0 [skip ci]

* chore: update to released telemetry lib

---------

Co-authored-by: svc-cli-bot <[email protected]>

---------

Co-authored-by: svc-cli-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants