Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable cargo miri #520

Closed
nikomatsakis opened this issue Jul 19, 2024 · 4 comments
Closed

re-enable cargo miri #520

nikomatsakis opened this issue Jul 19, 2024 · 4 comments

Comments

@nikomatsakis
Copy link
Member

nikomatsakis commented Jul 19, 2024 •
edited
Loading

I disabled miri tests in #518 because concurrent-vec is not miri safe and filed orxfun/orx-concurrent-vec#14 to track the underlying issue. We should either figure out why concurrent-vec is not miri-safe and fix it or adopt a new library (e.g., https://github.com/droundy/append-only-vec/ would meet our relatively simple needs if they land droundy/append-only-vec#4; we could fork too).
@droundy
Copy link

droundy commented Jul 19, 2024

I just released version 0.1.5 of append-only-vec with your PR included.

@nikomatsakis
Copy link
Member Author

Thanks!

@nikomatsakis
Copy link
Member Author

@droundy have you tested with miri, out of curiosity?

@nikomatsakis nikomatsakis mentioned this issue Jul 22, 2024
Merged
nikomatsakis added a commit to nikomatsakis/salsa that referenced this issue Aug 4, 2024
@nikomatsakis
stop ignoring miri
1bce41f 
Fixes salsa-rs#520
@davidbarsky
Copy link
Contributor

Closing this, as miri is re-enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@droundy @nikomatsakis @davidbarsky