add example test for fixpoint iteration #570
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test with a simplified example case where fixpoint iteration is needed in dataflow analysis.
Inputs are
Definition
,Use
, andLiteral
(to simplify the example, we exclude parsing and just take the data flow structure as input) modeling a simple language with only the following constructs:x = y + <literal>
orx = <literal>
.The added tests
simple
andunion
pass; the testscycle_converges
,cycle_diverges
, andmulti_symbol_cycle_converges
hit a Salsa cycle and fail.The initial goal of the fixpoint iteration feature (IMO) should be to make these tests pass (not exactly as-is; presumably some cycle-handling code will need to be added in some form, but exactly what that feature should look like is what we need to determine.)