-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor accumulators #575
Merged
nikomatsakis
merged 7 commits into
salsa-rs:master
from
nikomatsakis:refactor-accumulators
Sep 22, 2024
Merged
Refactor accumulators #575
nikomatsakis
merged 7 commits into
salsa-rs:master
from
nikomatsakis:refactor-accumulators
Sep 22, 2024
Commits on Sep 16, 2024
-
This will allow us to store the id in the struct itself.
Configuration menu - View commit details
-
Copy full SHA for 34a8edb - Browse repository at this point
Copy the full SHA 34a8edbView commit details -
change disambiguator_map to FxHashMap
There is no need for IndexMap here, we don't iterate or care about indices.
Configuration menu - View commit details
-
Copy full SHA for d7df2cd - Browse repository at this point
Copy the full SHA d7df2cdView commit details -
We used to have the concept of "resetting" a tracked struct, which removed all instances. We don't have that concept anymore. Therefore we don't need to record a read on the tracked struct table itself.
Configuration menu - View commit details
-
Copy full SHA for 2528045 - Browse repository at this point
Copy the full SHA 2528045View commit details
Commits on Sep 21, 2024
-
refactor
extend_memo_lifetime
to return memoThis is a step towards refactoring `fetch` to return the memo itself and not the value.
Configuration menu - View commit details
-
Copy full SHA for dcb0eb2 - Browse repository at this point
Copy the full SHA dcb0eb2View commit details -
return lifetime-extended memo, not value
Change the core operation to be `refresh_memo`. This is a nice refactoring on its own but it will also support the refactoring of how we manage accumulator values.
Configuration menu - View commit details
-
Copy full SHA for 2caa5cc - Browse repository at this point
Copy the full SHA 2caa5ccView commit details -
rework accumulator to store values in memos
We used to store values in a central map, but now each memo has an `AccumulatorMap` that maps accumulated values (if any). The primary goals of this change are * forward compatible with speculative execution because it puts more data into tables; * step towards a refactoring to stop tracking outputs in the same array as inputs and thus to simplify how we do versioning. We will no longer need to walk the function's outputs and refresh their versions and so forth because they are stored in the function memo and so they get refreshed automatically when the memo is refreshed.
Configuration menu - View commit details
-
Copy full SHA for 3687e48 - Browse repository at this point
Copy the full SHA 3687e48View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5af1d8 - Browse repository at this point
Copy the full SHA b5af1d8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.