show SharedState in Debug for Runtime #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be useful to debug deadlocks due to bad forking.
nikomatsakis
added a commit
to nikomatsakis/salsa
that referenced
this pull request
Dec 28, 2018
- Panic safety improvements (salsa-rs#81) - We build on stable now (salsa-rs#94) - Removed use of dynamic dispatch for constructing query descriptors (salsa-rs#95) - Technically a breaking change, though unlikely to affect clients - Removed use of upgradable reads to avoid Amanieu/parking-lot#101 (salsa-rs#75) - Upgraded parking lot (salsa-rs#100) - Improved Debug output (salsa-rs#98) - Snapshot implements Debug (salsa-rs#85)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show more info in
Runtime'sDebug.In rust-analyzer I am currntly debugging an issue where all queries are getting cancelled despite the fact that no modifications occur. I suspect this is due to some run-away runtime which prevents revision from being incremented, but I don't have a way to check this.
Printing locks and such from shared state should hopefully help.