Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to specify fields #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iterion
Copy link

@iterion iterion commented Feb 23, 2016

This is necessary in order to access information like CycleTimeDetails from the API (which I've also added here).

@iterion
Copy link
Author

iterion commented Feb 24, 2016

This change also suggests that we may want to consider adding something like:

type StoryOptions struct {
    Filters string
    Fields  string
}

And pass those options along to the appropriate methods. We could also move some of the encoding steps to a method on the StoryOptions struct.

I'd love some input on this.

@tchap
Copy link
Contributor

tchap commented Feb 24, 2016

Thanks, will get to this when I have some spare time...

@tchap
Copy link
Contributor

tchap commented Jul 12, 2018

@iterion Might be better to specify fields as ...string so that the interface actually doesn't change and existing code still compiles. We could do it another way I guess, but that would break the interface, which is better avoided unless there is a strong reason for it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants