fixup! initial draft for vault_pki

src/saltext/vault/states/vault_pki.py

@@ -378,24 +378,19 @@ def _diff_params(current):
             if not changes:
                 return ret
 
+        ret["changes"].update(changes)
+        if not current:
+            ret["changes"]["created"] = name
         if __opts__["test"]:
             ret["result"] = None
             ret["comment"] = (
                 f"PKI role `{name}` would have been {'updated' if current else 'created'}"
             )
-            ret["changes"].update(changes)
-            if not current:
-                ret["changes"]["created"] = name
             return ret
-
         __salt__["vault_pki.write_role"](
             name=name, mount=mount, issuer_ref=issuer_ref, ttl=ttl, max_ttl=max_ttl, **kwargs
         )
 
-        if not current:
-            ret["changes"]["created"] = name
-
-        ret["changes"].update(changes)
         ret["comment"] = f"PKI role `{name}` has been {'updated' if current else 'created'}"
     except (CommandExecutionError, SaltInvocationError) as err:
         ret["result"] = False