Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gitlab-ci): use GitLab CI as Travis CI replacement #52

Merged

Conversation

myii
Copy link
Member

@myii myii commented Dec 12, 2020

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@myii myii requested a review from a team as a code owner December 12, 2020 01:48
@myii myii force-pushed the feat/replace-Travis-CI-with-GitLab-CI branch 4 times, most recently from 8c65b58 to f286027 Compare December 13, 2020 16:09
@myii myii force-pushed the feat/replace-Travis-CI-with-GitLab-CI branch from f286027 to 99639ee Compare December 13, 2020 17:15
@myii myii merged commit 1bb521c into saltstack-formulas:master Dec 13, 2020
@myii myii deleted the feat/replace-Travis-CI-with-GitLab-CI branch December 13, 2020 18:42
@saltstack-formulas-travis

🎉 This PR is included in version 0.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@noelmcloughlin
Copy link
Member

@myii Nice work. I was wondering if you should keep the .travis.yml file (not delete) so that someone using the Formula who wants to use with their own Travis can do so?

@myii
Copy link
Member Author

myii commented Dec 16, 2020

@myii Nice work. I was wondering if you should keep the .travis.yml file (not delete) so that someone using the Formula who wants to use with their own Travis can do so?

@noelmcloughlin That was good timing because I was due to splurge the configuration to all repos (which I've done now). I've reinstated the .travis.yml, with a big warning at the top:

################################################################################
# NOTE: This file is UNMAINTAINED; it is provided for references purposes only.
# No guarantees are tendered that this structure will work after 2020.
################################################################################
# * https://en.wikipedia.org/wiki/Travis_CI:
# - "... free open-source plans were removed in [sic] the end of 2020"
# - https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing
# - https://ropensci.org/technotes/2020/11/19/moving-away-travis/
################################################################################

Maintaining two CI configurations is going to be too much work, so this should do for the time being.

myii added a commit to myii/ssf-formula that referenced this pull request Dec 17, 2020
Originally was this:

```
feat(travis): ensure `.travis.yml` is always removed
```

However, took this comment into account:

* saltstack-formulas/consul-formula#52 (comment)

But still removing `.travis.yml` for the `ssf-formula`.
myii pushed a commit to myii/ssf-formula that referenced this pull request Dec 17, 2020
# [1.227.0](v1.226.0...v1.227.0) (2020-12-17)

### Documentation

* **pre-commit:** fix `rstcheck` violations & add `pre-commit` info ([65ca911](65ca911))

### Features

* **arvados:** disable CI failures (e.g. EOL) ([3ec8673](3ec8673))
* **arvados:** review PRs 8, 9 & 10 ([d1459fd](d1459fd))
* **collectd:** disable CI failures (e.g. EOL) ([c00623c](c00623c))
* **deepsea:** disable CI failures (e.g. EOL) ([ba55b7a](ba55b7a))
* **dhcpd:** disable CI failures (e.g. EOL) ([9520f43](9520f43))
* **docker:** review PR 256 & defer CI testing until solution found ([0c52724](0c52724))
* **eclipse:** disable CI failures (e.g. EOL) ([ae5d5b2](ae5d5b2))
* **epel:** disable CI failures (e.g. EOL) ([d502105](d502105))
* **fail2ban:** disable CI failures (e.g. EOL) ([aa0d714](aa0d714))
* **gitlab-ci:** manage across formulas ([b0a854c](b0a854c))
* **icinga2:** defer CI testing until solution found ([1c62386](1c62386))
* **iscsi:** defer CI testing until solution found ([c11fc0c](c11fc0c))
* **jetbrains:** disable CI failures (e.g. EOL) ([f725bf6](f725bf6))
* **keepalived:** disable CI failures (e.g. EOL) ([f77527c](f77527c))
* **locale:** disable CI failures (e.g. EOL) ([e59d8b3](e59d8b3))
* **lvm:** defer CI testing until solution found ([ccb5525](ccb5525))
* **mongodb:** disable CI failures (e.g. EOL) ([decda2e](decda2e))
* **nginx:** disable CI failures (e.g. EOL) ([0df8214](0df8214))
* **openldap:** disable CI failures (e.g. EOL) ([2aa5466](2aa5466))
* **php:** disable CI failures (e.g. EOL) ([1779b88](1779b88))
* **platforms_matrix:** disable CI failures (e.g. EOL) ([7dd0b61](7dd0b61))
* **platforms_matrix_osfamily_debian:** disable CI failures (e.g. EOL) ([a96c71a](a96c71a))
* **platforms_matrix_without_arch:** disable CI failures (e.g. EOL) ([9be4992](9be4992))
* **pre-commit_semantic-release.sh:** install `m2r` without `sudo` ([887ff39](887ff39))
* **rabbitmq:** disable CI failures (e.g. EOL) ([e04739d](e04739d))
* **redis:** disable CI failures (e.g. EOL) ([2906da7](2906da7))
* **redis:** review PR 85 ([431f964](431f964))
* **release.config.js:** use parent repo for `repositoryUrl` ([a821435](a821435))
* **rkhunter:** disable CI failures (e.g. EOL) ([582622e](582622e))
* **rspamd:** disable CI failures (e.g. EOL) ([51092ec](51092ec))
* **salt:** adjust matrix to remove Fluorine `2019.2` ([63e2b42](63e2b42))
* **ssf:** use TOFS override for `CONTRIBUTING` document ([e8deac3](e8deac3))
* **stunnel:** disable CI failures (e.g. EOL) ([090ed85](090ed85))
* **suricata:** disable CI failures (e.g. EOL) ([c66a48d](c66a48d))
* **telegraf:** disable CI failures (e.g. EOL) ([7c16183](7c16183))
* **template:** disable CI failures (e.g. EOL) ([6b9e83a](6b9e83a))
* **template:** review PR 207 ([3f612cf](3f612cf))
* **template:** review PR 209 ([af7d43b](af7d43b))
* **tomcat:** disable CI failures (e.g. EOL) ([10e2af7](10e2af7))
* **travis:** provide curtailed `.travis.yml` for reference purposes ([cf3a4fb](cf3a4fb)), closes [/github.com/saltstack-formulas/consul-formula/pull/52#issuecomment-744533646](https://github.com//github.com/saltstack-formulas/consul-formula/pull/52/issues/issuecomment-744533646)
* **users:** disable CI failures (e.g. EOL) ([7ed56ff](7ed56ff))
* **varnish:** disable CI failures (e.g. EOL) ([e51c882](e51c882))
* **vault:** disable CI failures (e.g. EOL) ([dde4c9a](dde4c9a))
* **yamllint:** add `.cache/` to ignores (to use in GitLab CI) ([619aaee](619aaee))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants