Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Issues with repo install.sls in v1.0.0 #258

Closed
hkbakke opened this issue Nov 23, 2020 · 0 comments
Closed

[BUG] Issues with repo install.sls in v1.0.0 #258

hkbakke opened this issue Nov 23, 2020 · 0 comments
Labels

Comments

@hkbakke
Copy link

hkbakke commented Nov 23, 2020

https://github.com/saltstack-formulas/docker-formula/blob/master/docker/software/package/repo/install.sls has a couple of issues:

  1. refresh is misspelled as 'refesh'
  2. Onlyif seems to not be used correctly. As I have understood it should either specify a command or a module, not be fed a dictionary raw from pillar. I get the following warning when executing with a custom repo:
[WARNING ] no `fun` argument in onlyif: OrderedDict([('comments', ['installed by salt']), ('enabled', 1), ('gpgcheck', 1), ('name', 'deb [arch=amd64] http://mirror.example.com/download.docker.com/linux/debian buster stable'), ('file', '/etc/apt/sources.list.d/docker.list'), ('key_url', 'http://mirror.example.com/keys/docker.gpg.key')])                                       

Pillar:

docker:
  pkg:
    docker:
      use_upstream: package
      repo:
        name: deb [arch=amd64] http://mirror.example.com/download.docker.com/linux/debian {{ grains['oscodename'] }} stable
        key_url: http://mirror.example.com/keys/docker.gpg.key
@hkbakke hkbakke added the bug label Nov 23, 2020
noelmcloughlin added a commit to noelmcloughlin/docker-formula that referenced this issue Nov 23, 2020
noelmcloughlin added a commit to noelmcloughlin/docker-formula that referenced this issue Nov 23, 2020
noelmcloughlin added a commit that referenced this issue Dec 4, 2020
fix(repo): correct typo and explicit null-check #258
noelmcloughlin added a commit to noelmcloughlin/docker-formula that referenced this issue Dec 4, 2020
…ert-259-refresh

Revert "fix(repo): correct typo and explicit null-check saltstack-formulas#258"
saltstack-formulas-travis pushed a commit that referenced this issue Dec 18, 2020
# [1.1.0](v1.0.0...v1.1.0) (2020-12-18)

### Bug Fixes

* **clean:** correct package name ([58efc33](58efc33))
* **repo:** correct typo and explicit null-check [#258](#258) ([f5ec911](f5ec911))
* **typo:** refresh not refrsh ([f823af2](f823af2))
* **windows:** pip install docker ([b74bc08](b74bc08))

### Continuous Integration

* **gitlab-ci:** use GitLab CI as Travis CI replacement ([ab48dcd](ab48dcd))

### Features

* **arm64:** add support for Raspberry Pi 4 running Ubuntu 20.04 ([228ca07](228ca07))
* **proxy:** allow setting proxy in systemd ([ebeb2fe](ebeb2fe))
japtain-cack pushed a commit to japtain-cack/docker-formula that referenced this issue Jan 20, 2021
# [1.1.0](saltstack-formulas/docker-formula@v1.0.0...v1.1.0) (2020-12-18)

### Bug Fixes

* **clean:** correct package name ([58efc33](saltstack-formulas@58efc33))
* **repo:** correct typo and explicit null-check [saltstack-formulas#258](saltstack-formulas#258) ([f5ec911](saltstack-formulas@f5ec911))
* **typo:** refresh not refrsh ([f823af2](saltstack-formulas@f823af2))
* **windows:** pip install docker ([b74bc08](saltstack-formulas@b74bc08))

### Continuous Integration

* **gitlab-ci:** use GitLab CI as Travis CI replacement ([ab48dcd](saltstack-formulas@ab48dcd))

### Features

* **arm64:** add support for Raspberry Pi 4 running Ubuntu 20.04 ([228ca07](saltstack-formulas@228ca07))
* **proxy:** allow setting proxy in systemd ([ebeb2fe](saltstack-formulas@ebeb2fe))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants