Sorting keys breaks nginx.conf

[devster31]

Using a pillar like:

nginx:
  ng:
    server:
      config:
        http:
          log_format: "main '$remote_addr - $remote_user [$time_local] \"$request\" $status $body_bytes_sent \"$http_referer\"'" \"$http_user_agent\" \"$http_x_forwarded_for\""
          access_log: logs/access.log main

with the state nginx.ng.config produces an invalid nginx.conf since the access_log directive is put higher in the config and the log_format isn't defined yet.
Nginx HTTP Log Module Reference

[gravyboat]

We've actually tried to work around issues like this before with some fancy jinja templating. I feel like the only way to really get around it is to redesign how part of the ng formula works.

[mstarostik]

Ugly but practical workaround for the log_format case:

http:
  log_format: |-
    main '...';
        access_log /var/log/nginx/access_log main

EDIT: plus of course

  access_log: []

in order to suppress the default access_log option from being added.

On a side node: couldn't nginx.conf be generated with an orderd list in pillar like the managed vhosts are?

[noelmcloughlin]

Thanks @mstarostik I raised #208 to document your work.