Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes #181

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Misc fixes #181

wants to merge 2 commits into from

Conversation

dead10ck
Copy link

  • fix: handle process shutdown with limited permissions

Certain platforms like Android do not have permission to list all child processes. In this instance, just continue

  • remove dsa keys from test setup

DSA has been removed from openssh for some time now, and this causes running tests on newer machines to fail

Certain platforms like Android do not have permission to list all child
processes. In this instance, just continue
DSA has been removed from openssh for some time now, and this causes
running tests on newer machines to fail
@dead10ck dead10ck requested a review from a team as a code owner October 12, 2024 14:07
@dead10ck dead10ck requested review from Akm0d and removed request for a team October 12, 2024 14:07
@dmurphy18 dmurphy18 assigned dmurphy18 and unassigned dmurphy18 Oct 14, 2024
@dmurphy18
Copy link
Contributor

@dwoz How do you feel about removing dsa keys from salt-factories ?

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.98%. Comparing base (025dd47) to head (2235415).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/saltfactories/bases.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
- Coverage   85.27%   83.98%   -1.28%     
==========================================
  Files          97       97              
  Lines        5977     5705     -272     
  Branches      636      632       -4     
==========================================
- Hits         5096     4791     -305     
- Misses        705      721      +16     
- Partials      176      193      +17     
Flag Coverage Δ
Linux 83.98% <0.00%> (-0.72%) ⬇️
Windows ?
macOS ?
py3.10 ?
py3.7 83.98% <0.00%> (-0.02%) ⬇️
py3.8 ?
py3.9 ?
pytest-7.4.0 83.98% <0.00%> (-0.99%) ⬇️
pytest-8.0.0 ?
pytest-8.1.0 ?
salt-3006.0 83.98% <0.00%> (-0.99%) ⬇️
salt-3007.0 ?
src 83.98% <0.00%> (+6.71%) ⬆️
tests 95.88% <ø> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/saltfactories/daemons/sshd.py 75.18% <ø> (-1.45%) ⬇️
src/saltfactories/bases.py 76.48% <0.00%> (-1.54%) ⬇️

... and 68 files with indirect coverage changes

@dmurphy18
Copy link
Contributor

@dead10ck Even though the failures may not be due to your changes, can you look into why the tests are failing, wondering about that 3006.0 and 3007.0 given those are not the most recent versions of those branches

@dmurphy18
Copy link
Contributor

dmurphy18 commented Oct 17, 2024

@dead10ck Plan tp merge in your changes, but have to fix up the GitHub Actions , for example: Python 3.7 and 3.8, need to go, both EOL. Once that is fixed, will update / refresh this PR and it should build / test fine.

@dmurphy18 dmurphy18 enabled auto-merge (squash) October 17, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants