Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

SEP 36: salt-ssh configurable compression proposal #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nergdron
Copy link

This was recommended by @waynew on salt ticket 60479. It's a feature request to be able to configure the compression type and level used on thin tarballs for distribution by salt-ssh.

@welcome
Copy link

welcome bot commented Aug 30, 2021

Hello! Thank you for submitting a Salt Enhancement Proposal! Our process is detailed in the README.md and more about the SEP Life-cycle. An Open Core Team member will be assigned to follow up and help guide this SEP soon and you will find the this in the Community Slack channel #sep.
Please be sure to review our Code of Conduct.
You can also check out some of our community
resources:
- Community Wiki
- Salt’s Contributor Guide
- Join our Community Slack
- IRC on LiberaChat
- SaltStack YouTube channel
- SaltStackInc Twitch channel

@nergdron nergdron requested a review from a team as a code owner August 30, 2021 21:19
@nergdron nergdron requested review from dhiltonp and removed request for a team August 30, 2021 21:19
@waynew waynew changed the title salt-ssh configurable compression proposal SEP 36: salt-ssh configurable compression proposal Sep 13, 2021
@waynew
Copy link
Contributor

waynew commented Sep 13, 2021

This will be SEP 36 - feel free to update your filename/file contents 👍

@waynew
Copy link
Contributor

waynew commented Sep 13, 2021

👍 from me. I think it's a great idea, and it seems like something that would be straightforward to implement. The main risk that I see is around the config, as you called out in the SEP. We definitely have native minions that would have different compression tools available, but if we could use some kind of targeting similar to the way we do with top files, in theory that should solve the problem.

It may be possible that we have to ship that information alongside the thin, but I'm not positive, having not looked closely at that code lately 🙃.

I think it would be 100% possible to build up this functionality in layers - if we start with just allowing support for any of the built-in compression, we could merge that in and then work up to whatever alternative approaches we need.

@waynew
Copy link
Contributor

waynew commented Jan 5, 2022

Apologies for the long hiatus, we're working to refocus on getting SEPs through the process.


To summarize:

No objections have been made, a few possible approaches were mentioned. Given the gap, after next week we'll go ahead and put this into final comment period.

@waynew waynew added Draft Initial Status Final Comment Period Speak now or forever hold your peace. and removed Draft Initial Status labels Feb 15, 2022
@dmurphy18 dmurphy18 self-requested a review February 15, 2022 20:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Final Comment Period Speak now or forever hold your peace.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants