-
Notifications
You must be signed in to change notification settings - Fork 42
SEP 36: salt-ssh configurable compression proposal #58
base: master
Are you sure you want to change the base?
Conversation
Hello! Thank you for submitting a Salt Enhancement Proposal! Our process is detailed in the README.md and more about the SEP Life-cycle. An Open Core Team member will be assigned to follow up and help guide this SEP soon and you will find the this in the Community Slack channel #sep. |
This will be SEP 36 - feel free to update your filename/file contents 👍 |
👍 from me. I think it's a great idea, and it seems like something that would be straightforward to implement. The main risk that I see is around the config, as you called out in the SEP. We definitely have native minions that would have different compression tools available, but if we could use some kind of targeting similar to the way we do with top files, in theory that should solve the problem. It may be possible that we have to ship that information alongside the thin, but I'm not positive, having not looked closely at that code lately 🙃. I think it would be 100% possible to build up this functionality in layers - if we start with just allowing support for any of the built-in compression, we could merge that in and then work up to whatever alternative approaches we need. |
Apologies for the long hiatus, we're working to refocus on getting SEPs through the process. To summarize: No objections have been made, a few possible approaches were mentioned. Given the gap, after next week we'll go ahead and put this into final comment period. |
This was recommended by @waynew on salt ticket 60479. It's a feature request to be able to configure the compression type and level used on thin tarballs for distribution by
salt-ssh
.