Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Several Fixes and Improvements #12

Merged
merged 7 commits into from
Nov 5, 2021
Merged

Several Fixes and Improvements #12

merged 7 commits into from
Nov 5, 2021

Conversation

s0undt3ch
Copy link
Contributor

  • Allow not creating saltext namespaced packages
  • Use provided salt version from the CLI when rendering templates
  • Bump pytest-salt-factories version
  • Remove version lock from nox
  • Show an error when failing to render a Jinja templated file
  • Dedent extras_require

@s0undt3ch s0undt3ch requested a review from waynew October 28, 2021 06:02
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion, otherwise 👍

src/saltext/cli/__main__.py Outdated Show resolved Hide resolved
@waynew
Copy link
Contributor

waynew commented Nov 5, 2021

Complete sidenote - we should put together a smoke test for this that creates a Very Simple Project - basically just a 'hello world' module, installs it, and ensures that it will run with Salt

Signed-off-by: Pedro Algarvio <[email protected]>
@s0undt3ch s0undt3ch merged commit f502e18 into saltstack:main Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants