Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FQDNs grains generate errors in IPv6 #52788

Closed
aplanas opened this issue May 2, 2019 · 3 comments · Fixed by #51706
Closed

FQDNs grains generate errors in IPv6 #52788

aplanas opened this issue May 2, 2019 · 3 comments · Fixed by #51706
Labels
Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged
Milestone
Blocked

Comments

@aplanas
Copy link
Contributor

aplanas commented May 2, 2019

Description of Issue/Question

My salt-master is over a host that contains IPv4 and IPv6 addresses, and not all the IPv6 can be resolved by a DNS.

The grains in core try to resolve all the IPs, but not all of them can be resolved, so my master log errors like this ones:

[ERROR   ] Exception during resolving address: [Errno 1] Unknown host

[ERROR   ] Exception during resolving address: [Errno 4] No address associated with name

Those errors correspond to the HOST_NOT_FOUND and NO_DATA from the socket API.

Setup

Any deployment of develop will recreate the issue

Versions Report

develop branch
@waynew waynew added the Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged label May 3, 2019
@waynew waynew added this to the Blocked milestone May 3, 2019
@waynew
Copy link
Contributor

waynew commented May 3, 2019

I could be wrong, but it seems like this is behavior that we would like to have, or at least optionally turn off. @saltstack/team-core @saltstack/team-network do you have any thoughts here?

@aplanas aplanas mentioned this issue May 4, 2019
Merged
@aplanas
Copy link
Contributor Author

aplanas commented May 4, 2019

If I understand the problem, Error 1 will never go away as is an IPv6 that will never have a domain name associated, and I do not see this as an error per se.

Error 4 is when an old IPv6 disappear from the resolver, something that, looks like, can happen frequently as there is some kind of temporary IPv6 or something. If this is correct, I would thing that this is neither an error relevant to be logged (maybe a WARNING or an INFO)

@aplanas aplanas mentioned this issue Jun 11, 2019
Closed
aplanas added a commit to aplanas/salt that referenced this issue Aug 29, 2019
@aplanas
grains/core: ignore HOST_NOT_FOUND errno in fqdns()
926b9db 
Also ignore NO_DATA errors, as this imply an empty field

Fixes saltstack#52788

(cherry picked from commit 816ee23bb11a5bca3930f8e98166f498b5bcee33)
@aplanas
Copy link
Contributor Author

aplanas commented Oct 14, 2019

The fix is rebased on master now

aplanas added a commit to aplanas/salt that referenced this issue Dec 3, 2019
@aplanas
grains/core: ignore HOST_NOT_FOUND errno in fqdns()
d4d0901 
Also ignore NO_DATA errors, as this imply an empty field

Fixes saltstack#52788
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged
Projects
None yet
Milestone
Blocked
Development

Successfully merging a pull request may close this issue.

grains/core: ignore HOST_NOT_FOUND errno in fqdns() aplanas/salt
2 participants
@waynew @aplanas