Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Support IMDSv2 for retrieving EC2 Metadata grains #57514

Closed
lorengordon opened this issue Jun 1, 2020 · 3 comments
Closed
Labels
Feature new functionality including changes to functionality and code refactors, etc. Grains
Milestone

Comments

@lorengordon
Copy link
Contributor

lorengordon commented Jun 1, 2020

Is your feature request related to a problem? Please describe.

AWS has released a new EC2 Metadata protocal, IMDSv2, that requires passing an authentication token when querying for EC2 Metadata. The token can be retrieved programatically. The old method, now dubbed IMDSv1, can be disabled entirely, which breaks the method salt is currently using to retrieve EC2 Metadata grains.

Describe the solution you'd like

  • Attempt to retrieve the token.
  • If successful, IMDSv2 is enabled, set method to IMDSv2.
  • If not successful, set method to IMDSv1.
  • Attempt to retrieve ec2 metadata with selected method.

Additional context

@lorengordon lorengordon added the Feature new functionality including changes to functionality and code refactors, etc. label Jun 1, 2020
@dmurphy18 dmurphy18 added this to the Approved milestone Jun 1, 2020
@onepeloton-nick
Copy link

Hey all, just curious if there is movement on this at all... been a long time since any updates

@lorengordon
Copy link
Contributor Author

There's a chance this is addressed in Salt 3006, based on #63067. If anyone following has tested it, would appreciate a report back! Thanks!

@lorengordon
Copy link
Contributor Author

I believe this is now working in salt 3006, per the linked PR, so I'm going to close this ticket.

lorengordon added a commit to lorengordon/imdsv2_wall_of_shame that referenced this issue May 30, 2023
After testing salt 3006, I can confirm IMDSv2 is working correctly. I've closed the [linked issue](saltstack/salt#57514).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature new functionality including changes to functionality and code refactors, etc. Grains
Projects
None yet
Development

No branches or pull requests

4 participants