[BUG] malformed event return on 3006.5

[danielbakken]

Description
After updating the salt master to 3006.5, salt commands report the following warning, regardless of whether minions are running 3006.5 or 3006.3:

[WARNING ] Malformed event return: salt/job/20231218152520826404/returning

This warning does not occur on Salt 3006.3.

Steps to Reproduce the behavior
Upgrade salt master to 3006.5. Run salt '*' grains.get saltversion or any other salt command.

Expected behavior
Return status is reported without warnings.

Versions Report

salt --versions-report

Salt Version: Salt: 3006.5

Python Version:
Python: 3.10.13 (main, Nov 15 2023, 04:34:27) [GCC 11.2.0]

Dependency Versions:
cffi: 1.14.6
cherrypy: unknown
dateutil: 2.8.1
docker-py: Not Installed
gitdb: Not Installed
gitpython: Not Installed
Jinja2: 3.1.2
libgit2: Not Installed
looseversion: 1.0.2
M2Crypto: 0.38.0
Mako: Not Installed
msgpack: 1.0.2
msgpack-pure: Not Installed
mysql-python: Not Installed
packaging: 22.0
pycparser: 2.21
pycrypto: Not Installed
pycryptodome: 3.9.8
pygit2: Not Installed
python-gnupg: 0.4.8
PyYAML: 6.0.1
PyZMQ: 23.2.0
relenv: 0.14.2
smmap: Not Installed
timelib: 0.2.4
Tornado: 4.5.3
ZMQ: 4.3.4

Salt Extensions:
SSEAPE: 8.14.1.5

System Versions:
dist: rhel 8.9 Ootpa
locale: utf-8
machine: x86_64
release: 4.18.0-513.9.1.el8_9.x86_64
system: Linux
version: Red Hat Enterprise Linux 8.9 Ootpa

[dwoz]

@danielbakken

Thanks for the report. Can you please monitor the event bus while you run the job and provide us the output?
https://docs.saltproject.io/en/getstarted/event/events.html

[danielbakken]

return-event.txt

The output of salt-run state.event pretty=True is attached.

[nathansayshi]

Can confirm that I am seeing this as well when running jobs from the command line. I am also connecting to Aria Automation Config with the SSEAPE extension. Possibly a mismatch between what AAC is sending through the sseapi returner and what 3006.5 is expecting?

EDIT: Looks like that log entry is coming from salt/lib/python3.10/site-packages/salt/client/init.py, at least for a onedir install.

if "return" not in raw["data"]:
   log.warning("Malformed event return: %s", raw["tag"])
   continue

[whytewolf]

so the only line added to that was the log.warning line. but that does look like were it is coming from.

from what i can see sseape is adding 2 events salt/job/<jid>/return and salt/job/<jid>/complete. those events do not come from salt normally.

the return event is getting caught up in that code because it starts with salt/job/<jid>/ret which is how a job return starts.

it looks like no other functionality is changed so the warning can be ignored. @dwoz should we add the / to the end of the startswith line, change the logging to debug since it looks harmless, or get sseapi to label their events differently?

[whytewolf]

closing since merged. will release with 3006.7