Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] return event greednes fix. #66010

Merged
merged 6 commits into from
Feb 14, 2024
Merged

Conversation

whytewolf
Copy link
Collaborator

@whytewolf whytewolf commented Feb 6, 2024

What does this PR do?

What issues does this PR fix or reference?

Fixes: #65727

Previous Behavior

catch all salt/job/{jid}/ret*

New Behavior

catch only salt/job/{jid}/ret/*

@dwoz wanted to see about tests for this. i couldn't figure out how to thread the class function that this is happening in.

the fix is super simple. testing it not so much.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

@whytewolf whytewolf requested a review from a team as a code owner February 6, 2024 17:21
@whytewolf whytewolf requested review from twangboy and removed request for a team February 6, 2024 17:21
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Return fix [3006.x] Return fix Feb 6, 2024
@whytewolf whytewolf changed the title [3006.x] Return fix [3006.x] return event greednes fix. Feb 6, 2024
@whytewolf whytewolf requested a review from dwoz February 6, 2024 17:23
@twangboy
Copy link
Contributor

twangboy commented Feb 9, 2024

I think it's still happening... at least on MacOS

@whytewolf
Copy link
Collaborator Author

I think it's still happening... at least on MacOS

the mac errors look to be unrelated.

 ERROR tests/pytests/functional/modules/state/test_jinja_filters.py::test_filter[hmac] - AttributeError: module 'py' has no attribute 'io'
ERROR tests/pytests/functional/modules/state/test_jinja_filters.py::test_filter[gen_mac] - AttributeError: module 'py' has no attribute 'io'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants