Revert "Make possible to reference previous pillars from subsequent pillars, as they specified in the top file" #42383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #37003
I noticed a problem in #37003: in this place,
functions
that are passed inthe constructor are ignored, which is not right.
Let's revert the previous PR.
I see the way to fix it - remove
functions
parameter from Pillar interface,which would affect
Pillar
,PillarCache
,RemotePillar
,RemotePillar
,AsyncPillar
,AsyncRemotePillar
classes aswell as the factories:
get_pillar
,get_async_pillar
. It would encapsulate modules loading within Pillar classes.@cachedout, @terminalmage, @s0undt3ch, @thatch45, what are your thoughts on this?
Are there any fundamental objections against removing
functions
parameter?The only place where this parameter is actually used is here.