preserve tuples for ldap modification operations

[nullify005]

What does this PR do?

Preserves the tuples which are passed into the decoding method for ldap modify operations

What issues does this PR fix or reference?

Fixes #46887 (comment)

Specifically:

          ID: slapd suffix
    Function: ldap.managed
      Result: False
     Comment: An exception occurred in this state: Traceback (most recent call last):
                File "/usr/lib/python2.7/dist-packages/salt/state.py", line 1905, in call
                  **cdata['kwargs'])
                File "/usr/lib/python2.7/dist-packages/salt/loader.py", line 1830, in wrapper
                  return f(*args, **kwargs)
                File "/usr/lib/python2.7/dist-packages/salt/states/ldap.py", line 334, in managed
                  __salt__['ldap3.add'](l, dn, n)
                File "/usr/lib/python2.7/dist-packages/salt/modules/ldap3.py", line 417, in add
                  l.c.add_s(dn, modlist)
                File "/usr/lib/python2.7/dist-packages/ldap/ldapobject.py", line 209, in add_s
                  msgid = self.add(dn,modlist)
                File "/usr/lib/python2.7/dist-packages/ldap/ldapobject.py", line 206, in add
                  return self.add_ext(dn,modlist,None,None)
                File "/usr/lib/python2.7/dist-packages/ldap/ldapobject.py", line 191, in add_ext
                  return self._ldap_call(self._l.add_ext,dn,modlist,RequestControlTuples(serverctrls),RequestControlTuples(clientctrls))
                File "/usr/lib/python2.7/dist-packages/ldap/ldapobject.py", line 106, in _ldap_call
                  result = func(*args,**kwargs)
              TypeError: ('expected a tuple', ['objectClass', ['top', 'dcObject', 'organization']])
     Started: 03:49:06.574923
    Duration: 7.598 ms
     Changes: 

Which I traced to this in modules/ldap3.py before & after the utils.data.decode:

[DEBUG   ] ====> modlist before: [(0, u'olcRootPW', [u'{SSHA}whatever'])]
[DEBUG   ] ====> modlist after: [[0, 'olcRootPW', ['{SSHA}whatever']]]

Notice that the inner tuple gets converted to a list which the underlying ldap library isn't fond of

Turning on preserve_tuples fixes the issue

Previous Behavior

ldap modify operations fail

New Behavior

ldap modify operations succeed

Tests written?

No

Commits signed with GPG?

No

[nullify005]

Can we also get this backported to 2018.3 pretty please?

[ghost]

FYI: Tested & approved, it fixes ldap entries creations & modifications.

[terminalmage]

@rallytime this needs a backport to 2018.3

EDIT: nvm I see you're already on top of it 😄

[rallytime]

@nullify005 I am happy to backport this, but in the future, feel free to submit bug fixes to their appropriate branches. We will then merge them forward. You can learn more here if you're interested on how we manage this. :)