[develop] x509 additional certificate & csr extensions #49102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sions. These extensions can be passed as additional kwargs and made valid using the ext_mapping dictionary argument.
rallytime
approved these changes
Aug 14, 2018
|
I'd ike to have @clinta look at if he's able to. |
terminalmage
approved these changes
Aug 14, 2018
|
LGTM, a nice way to make this module extensible. |
garethgreenaway
added a commit
to garethgreenaway/salt
that referenced
this pull request
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A change to allow additional supported X509 certificate and CSR extensions. These extensions can be passed as additional kwargs and made valid using the ext_mapping dictionary argument.
What issues does this PR fix or reference?
N/A
Previous Behavior
Additional extensions would be ignored.
New Behavior
Using the
ext_mappingparameter, additional extensions can be used.Tests written?
Yes
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.