Add webconfiguration settings management (module + state). #49399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
twangboy
approved these changes
Aug 29, 2018
twangboy
requested changes
Aug 29, 2018
salt/modules/win_iis.py
Outdated
|
|
||
|
|
||
| def set_webconfiguration_settings(name, settings): | ||
| ''' |
salt/states/win_iis.py
Outdated
|
|
||
|
|
||
| def webconfiguration_settings(name, settings=None): | ||
| ''' |
twangboy
approved these changes
Aug 29, 2018
twangboy
requested changes
Aug 29, 2018
salt/modules/win_iis.py
Outdated
| ''' | ||
| prepared_settings = [] | ||
| for setting in settings: | ||
| match = re.search('Collection\[(\{.*\})\]', setting['name']) |
There was a problem hiding this comment.
This line is failing lint as well... Might need to add an r here. Not sure how that would affect the regex though. You'll need to test.
There was a problem hiding this comment.
If it must be formatted like this, then you'll need to skip the lint test for this line by adding this to the end:
# pylint: disable=W1401
There should be two spaces between the end of the code and the #
There was a problem hiding this comment.
The backslashes here are not interpreted by Python in any way ( neither \[ nor \{ means something ). So it is safe to add the raw prefix. I tested it, it works.
twangboy
approved these changes
Aug 30, 2018
|
@rallytime Could we get this in to Fluorine? It fixes a customer issue. |
|
@tlemarchand Great work! Thanks for the PR. |
cachedout
suggested changes
Aug 31, 2018
twangboy
approved these changes
Aug 31, 2018
cachedout
approved these changes
Sep 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add webconfiguration settings management, inside win_iis module ( get and set webconfigurations ) and win_iis state ( define webconfigurations ).
This is necessary to manage all possible IIS configurations.
What issues does this PR fix or reference?
#48792
Tests written?
No
Commits signed with GPG?
No