Add new module freezer #50452

aplanas · 2018-11-09T14:57:30Z

What does this PR do?

Sometimes we need to have a static picture of the repositories
and packages installed in a system, so we can install new transient
packages (and the dependencies) and be able to go back to a previous
state where those packages are not there anymore.

This module allows the user to take this picture, and revert all
the changes done after this picture. We can remove package,
reinstall packages that are missing, and do the same for repositories.

Tests written?

Yes

aplanas · 2018-11-09T16:42:32Z

This little module is ready for review. I am not sure if the utility is general enough, but is covering my use cases.

salt/modules/freezer.py

tests/unit/modules/test_freezer.py

salt/modules/freezer.py

terminalmage · 2018-11-14T22:11:08Z

salt/modules/freezer.py

+
+    As this module is build on top of the pkg module, the user can
+    send extra attributes to the underlying pkg module via kwargs. For
+    this command we can influence pkg.list_repos, pkg.mod_repo,


Again, the wording in this sentence is not quote right. Instead, let's use the example I suggested above.

Sometimes we need to have a static picture of the repositories and packages installed in a system, so we can install new transient packages (and the dependencies) and be able to go back to a previous state where those packages are not there anymore. This module allows the user to take this picture, and revert all the changes done after this picture. We can remove package, reinstall packages that are missing, and do the same for repositories.

saltstack/salt#49668 saltstack/salt#49669 saltstack/salt#49670 saltstack/salt#49803 saltstack/salt#49804 saltstack/salt#50126 saltstack/salt#50175 saltstack/salt#50302 saltstack/salt#50380 saltstack/salt#50396 saltstack/salt#50418 saltstack/salt#50452 saltstack/salt#50473 saltstack/salt#50541 saltstack/salt#50607 saltstack/salt#50635 saltstack/salt#50671 saltstack/salt#50706 saltstack/salt#50725 saltstack/salt#50801 saltstack/salt#50834 saltstack/salt#51074 saltstack/salt#51094 saltstack/salt#51135

* blockdev: fix url from comment saltstack/salt#49668 * Documentation: fix typo in "equivalent" saltstack/salt#49669 * states_pt3: fix rST link format saltstack/salt#49670 * parted: fix _validate_partition_boundary saltstack/salt#49803 * parted: fix the ordering of list command saltstack/salt#49804 * Fix lowpkg.diff documentation and parameter name saltstack/salt#50126 * Add root parameter to useradd, shadow and groupadd saltstack/salt#50175 * cmd: Add root parameter for wait and run states saltstack/salt#50302 * systemd: add optional root parameter saltstack/salt#50380 * service: SUSE is not based on sysvinit anymore saltstack/salt#50396 * Add new chroot module saltstack/salt#50418 * Add new module freezer saltstack/salt#50452 * parted: support variable length output for print saltstack/salt#50473 * btrfs: add all subvolume commands saltstack/salt#50541 * file: update attributes for lsattr and chattr saltstack/salt#50607 * btrfs: add new btrfs state saltstack/salt#50635 * zypper: demote log from error to warning saltstack/salt#50671 * blkid: add search by token saltstack/salt#50706 * mount: add fstab_{present,absent} states saltstack/salt#50725 * btrfs: add option to not set subvolumes as default saltstack/salt#50801 * Add disk_set and disk_toggle functions, and update valid partition flags saltstack/salt#50834 * disk: support setting FAT size for format_ saltstack/salt#51074 * cmdmod: add sysfs into the chroot saltstack/salt#51094 * mount: cache blkid information saltstack/salt#51135

* Add root and no_recommends parameters in the public interface for Zypper and RPM (lowpkg) saltstack/salt#50125 * Add root parameter to useradd, shadow and groupadd saltstack/salt#50175 * cmd: Add root parameter for wait and run states saltstack/salt#50302 * systemd: add optional root parameter saltstack/salt#50380 * Add new chroot module https://github.com/openSUSE/salt/pull/50418 * Add new module freezer saltstack/salt#50452 * btrfs: add all subvolume commands saltstack/salt#50541 * btrfs: add new btrfs state saltstack/salt#50635 * zypper: demote log from error to warning saltstack/salt#50671 * blkid: add search by token saltstack/salt#50706 * mount: add fstab_{present,absent} states saltstack/salt#50725 * btrfs: add option to not set subvolumes as default https://github.com/openSUSE/salt/pull/50801 * Add disk_set and disk_toggle functions, and update valid partition flags https://github.com/openSUSE/salt/pull/50834 * disk: support setting FAT size for format_ https://github.com/openSUSE/salt/pull/51074 * parted: fix set_ valid flags comment. https://github.com/openSUSE/salt/pull/51704 * grains/core: ignore HOST_NOT_FOUND errno in fqdns() https://github.com/openSUSE/salt/pull/51706 * cmdmod: add 'binds' parameter in run_chroot https://github.com/openSUSE/salt/pull/51871 * mount: fix extra -t parameter https://github.com/openSUSE/salt/pull/51905 * lvm: be quiet when a pv, lv or vg is not expected https://github.com/openSUSE/salt/pull/51929 * linux_lvm: clean error in pvcreate and pvremove https://github.com/openSUSE/salt/pull/51954 * blockdev: hide blkid errors when are expected https://github.com/openSUSE/salt/pull/51956 * partially unify public functions signature for pkg and lowpkg https://github.com/openSUSE/salt/pull/51973 * extmods: add utils directories in sys.path https://github.com/openSUSE/salt/pull/52001

* Add root and no_recommends parameters in the public interface for Zypper and RPM (lowpkg) saltstack/salt#50125 * Add root parameter to useradd, shadow and groupadd saltstack/salt#50175 * cmd: Add root parameter for wait and run states saltstack/salt#50302 * systemd: add optional root parameter saltstack/salt#50380 * Add new chroot module https://github.com/openSUSE/salt/pull/50418 * Add new module freezer saltstack/salt#50452 * btrfs: add all subvolume commands saltstack/salt#50541 * btrfs: add new btrfs state saltstack/salt#50635 * zypper: demote log from error to warning saltstack/salt#50671 * blkid: add search by token saltstack/salt#50706 * mount: add fstab_{present,absent} states saltstack/salt#50725 * btrfs: add option to not set subvolumes as default saltstack/salt#50801 * Add disk_set and disk_toggle functions, and update valid partition flags saltstack/salt#50834 * disk: support setting FAT size for format_ saltstack/salt#51074 * parted: fix set_ valid flags comment. saltstack/salt#51704 * grains/core: ignore HOST_NOT_FOUND errno in fqdns() saltstack/salt#51706 * cmdmod: add 'binds' parameter in run_chroot saltstack/salt#51871 * mount: fix extra -t parameter saltstack/salt#51905 * lvm: be quiet when a pv, lv or vg is not expected saltstack/salt#51929 * linux_lvm: clean error in pvcreate and pvremove saltstack/salt#51954 * blockdev: hide blkid errors when are expected saltstack/salt#51956 * partially unify public functions signature for pkg and lowpkg saltstack/salt#51973 * extmods: add utils directories in sys.path saltstack/salt#52001

aplanas force-pushed the fix_freezer branch 5 times, most recently from 83054d3 to 650d576 Compare November 9, 2018 16:22

aplanas changed the title ~~Add new module freezer.~~ Add new module freezer Nov 9, 2018

aplanas force-pushed the fix_freezer branch 2 times, most recently from 84acb00 to c98a804 Compare November 9, 2018 16:36

cachedout reviewed Nov 13, 2018

View reviewed changes

salt/modules/freezer.py Outdated Show resolved Hide resolved

salt/modules/freezer.py Show resolved Hide resolved

aplanas force-pushed the fix_freezer branch from c98a804 to 70c8ae2 Compare November 14, 2018 09:33

isbm suggested changes Nov 14, 2018

View reviewed changes

aplanas force-pushed the fix_freezer branch from 70c8ae2 to 7dcb21a Compare November 14, 2018 15:14

terminalmage suggested changes Nov 14, 2018

View reviewed changes

aplanas force-pushed the fix_freezer branch 2 times, most recently from da82d16 to a7469b8 Compare November 14, 2018 16:52

terminalmage suggested changes Nov 14, 2018

View reviewed changes

aplanas force-pushed the fix_freezer branch from a7469b8 to efcce01 Compare November 15, 2018 10:01

rallytime requested review from cachedout, terminalmage and isbm November 15, 2018 14:50

terminalmage approved these changes Nov 15, 2018

View reviewed changes

cachedout merged commit 4ae01b9 into saltstack:develop Nov 16, 2018

aplanas mentioned this pull request Jan 30, 2019

Backport from develop features required by yomi openSUSE/salt#120

Closed

aplanas deleted the fix_freezer branch April 24, 2019 08:22

aplanas mentioned this pull request Oct 11, 2019

(Backport 50452, 54022) Add new module freezer #54960

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new module freezer #50452

Add new module freezer #50452

aplanas commented Nov 9, 2018 •

edited

Loading

aplanas commented Nov 9, 2018

terminalmage Nov 14, 2018

Add new module freezer #50452

Add new module freezer #50452

Conversation

aplanas commented Nov 9, 2018 • edited Loading

What does this PR do?

Tests written?

aplanas commented Nov 9, 2018

terminalmage Nov 14, 2018

Choose a reason for hiding this comment

aplanas commented Nov 9, 2018 •

edited

Loading