Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: OS arch fall-back when no RPM installed on inird image #50523

Merged
merged 10 commits into from
Nov 20, 2018

Conversation

isbm
Copy link
Contributor

@isbm isbm commented Nov 15, 2018

What does this PR do?

Bugfix.

What issues does this PR fix or reference?

Salt is unable to determine OS architecture grain on initrd Linux images for RPM systems.

Previous Behavior

OS architecture is not detected.

New Behavior

OS architecture is detected.

Tests written?

Yes

@ghost ghost self-requested a review November 15, 2018 10:31
@isbm
Copy link
Contributor Author

isbm commented Nov 15, 2018

Package is out here.

@rallytime rallytime requested a review from a team November 15, 2018 14:49
@cachedout
Copy link
Contributor

@isbm There are some lint errors here, it seems

@isbm isbm force-pushed the isbm-inird-no-rpm-platform-fix branch 2 times, most recently from 073447d to fd5db89 Compare November 17, 2018 11:43
@isbm
Copy link
Contributor Author

isbm commented Nov 20, 2018

@cachedout As of lint, seems it is not related to this PR: integration/test_nacl.py is something I didn't touched, apparently.

@isbm isbm force-pushed the isbm-inird-no-rpm-platform-fix branch from 4260d18 to f8deae2 Compare November 20, 2018 09:23
@isbm
Copy link
Contributor Author

isbm commented Nov 20, 2018

@cachedout OK, lint error gone after rebase on develop. 😕 So should be OK now.

@cachedout cachedout merged commit 56d8a7e into saltstack:develop Nov 20, 2018
garethgreenaway added a commit to garethgreenaway/salt that referenced this pull request Sep 19, 2019
dwoz added a commit that referenced this pull request Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants