Implement version_clean & check_extra_requirements in opkg module #50938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplement-extra-requirements-and-version-clean
…ts-and-version-clean
garethgreenaway
added a commit
to garethgreenaway/salt
that referenced
this pull request
Dec 3, 2019
dwoz
added a commit
that referenced
this pull request
Dec 29, 2019
[master] Porting #50938 to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implement pkg.version_clean & pkg.check_extra_requirements in the opkg execution module
Previous Behavior
The time it took to apply a state that contained many (in our case ~400) of packages, when all of the packages were installed was ~11 minutes.
The package state module checks if the pkg module has defined the version_clean and check_extra_requirements_functions in a for loop that iterates through all the packages. Therefore, if the two functions are not defined, the lazy loader will always fail, leading to poor performance.
An alternative would be to cache the function before entering the for loop but that is a little bit trickier to do since, the actual call to version_clean & check_extra_requirements functions are done via a different execution module called pkg_resource. We would not want to cache pkg_resource.version_clean, as that one will always exist. We would want to cache pkg.version_clean because that one might not exist for every 'pkg' module.
New Behavior
The time it takes to apply a state that contains many (in our case ~400) of packages, when all of the packages are installed is 9 seconds.
Tests written?
No
Commits signed with GPG?
No