Don't log debug messages during close

[cachedout]

This can hit race conditions where we might not have a fully functional logger.

Prevents a stacktrace that looks like:

Exception ignored in: <bound method RemoteClient.__del__ of <salt.fileclient.RemoteClient object at 0x7f5e98add2b0>>
Traceback (most recent call last):
  File "/opt/behavox/.local/lib/python3.6/site-packages/salt/fileclient.py", line 1026, in __del__
  File "/opt/behavox/.local/lib/python3.6/site-packages/salt/fileclient.py", line 1033, in destroy
  File "/opt/behavox/.local/lib/python3.6/site-packages/salt/utils/asynchronous.py", line 62, in wrap
  File "/opt/behavox/.local/lib/python3.6/site-packages/salt/transport/zeromq.py", line 227, in close
  File "/usr/lib64/python3.6/logging/__init__.py", line 1295, in debug
  File "/opt/behavox/.local/lib/python3.6/site-packages/salt/log/setup.py", line 343, in _log
  File "/usr/lib64/python3.6/logging/__init__.py", line 1442, in _log
  File "/opt/behavox/.local/lib/python3.6/site-packages/salt/log/setup.py", line 363, in makeRecord
NameError: name '__salt_system_encoding__' is not defined

Credit to @Oloremo for finding this. :)

[cachedout]

This will need to be backported too.

[Oloremo]

This fix looks trivial enough to be ported to 2019.2.1, could you please do this?

[Oloremo]

Sorry for the noise, looks like it's been already ported.

[Ch3LL]

yep it will be in 2019.2.1 as you can see here: https://github.com/saltstack/salt/blob/v2019.2.1/salt/transport/zeromq.py#L236

[dawidmalina]

I have quite similar issue and unfortunately this fix will not address this:

Exception ignored in: <bound method AsyncZeroMQReqChannel.__del__ of <salt.transport.zeromq.AsyncZeroMQReqChannel object at 0x7f8717e2c5f8>>
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/salt/transport/zeromq.py", line 249, in __del__
  File "/usr/lib/python3/dist-packages/salt/transport/zeromq.py", line 227, in close
  File "/usr/lib/python3.6/logging/__init__.py", line 1296, in debug
  File "/usr/lib/python3/dist-packages/salt/log/setup.py", line 343, in _log
  File "/usr/lib/python3.6/logging/__init__.py", line 1443, in _log
  File "/usr/lib/python3/dist-packages/salt/log/setup.py", line 363, in makeRecord
NameError: name '__salt_system_encoding__' is not defined

[Ch3LL]

@dawidmalina would you mind opening up an issue with details of when you are running into this issue?