Add git_pillar interval timer to control how often git remotes are checked

[Tanoti]

What does this PR do?

Add support for new config option git_pillar_interval so git_pillar data can be collected less frequently than the main loop_interval timer allows

What issues does this PR fix or reference?

N/A

Previous Behavior

Git pillar remotes would be checked using the loop_interval timer value (e.g. every 60 seconds).

New Behavior

Git pillar remotes can be checked using a different interval to the loop_interval. For example, if the git pillar data is not likely to change very often then a higher value such as 300 seconds could be used which would reduce the load on the git repo server by a factor of five.

Tests written?

No

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

[dwoz]

@Tanoti can you write some basic tests for this?

[Tanoti]

@dwoz Please point me to some similar tests and I'll take a look. Not sure how far the tests have to go (i.e. just checking the option is parsed or that it actually works)?

[cachedout]

Is this intended to be a user-configurable option? If so, it needs documentation. Additionally, it would need to be added to the configuration handling code in salt.config.

[sathieu]

@Tanoti Also the config should be named git_pillar_update_interval to match gitfs_update_interval.

[sathieu]

Using another loop would be better (like gitfs does), but this is probably harder. See 958c99b and

salt/salt/master.py

Line 357 in a8fc7be

class FileserverUpdate(salt.utils.process.SignalHandlingMultiprocessingProcess):

[sathieu]

Superseded by #53621.

[waynew]

@sathieu so should we go ahead and close this PR then?

[sathieu]

@waynew Yes I think. Unless @Tanoti wants to keep working on it.

[Tanoti]

@sathieu I'm happy for this to be closed. I've not had time to look at it any further so thanks for moving it on.