Stops the Window installer from hanging #52365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Removed “-NoNewWindow” which was the cause of the hang when pip ran *Cleaned up start-process-and-test-exitcode.psm1 *Switched the order of Removed Temporary and script complete in “build_env_3.ps1” *www.github.com/saltstack/salt/issues/52265
twangboy
requested changes
Mar 30, 2019
twangboy
requested changes
Apr 8, 2019
twangboy
approved these changes
Apr 9, 2019
garethgreenaway
added a commit
to garethgreenaway/salt
that referenced
this pull request
Sep 18, 2019
dwoz
added a commit
that referenced
this pull request
Dec 29, 2019
[master] Porting #52365 to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Removed “-NoNewWindow” which was the cause of the hang when pip ran
*Cleaned up start-process-and-test-exitcode.psm1
*Switched the order of Removed Temporary and script complete in “build_env_3.ps1”
*www.github.com/saltstack/salt/issues/52265
What does this PR do?
*Removed “-NoNewWindow” which was the cause of the hang when pip ran
*Cleaned up start-process-and-test-exitcode.psm1
*Switched the order of Removed Temporary and script complete in “build_env_3.ps1”
What issues does this PR fix or reference?
www.github.com/saltstack/salt/issues/52265
Tests written?
No
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.